Add taint for critical components not ready after update #1017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After a successful in-place update, the controller now adds the 'critical components not ready' taint to the node. This prevents pods from being scheduled until critical component pods are ready, improving node readiness handling.
gardener-robot
added
needs/review
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
added
needs/ok-to-test
After a successful inplace update, the PreferNoSchedule taint is now removed from the node if present. This ensures that nodes are properly untainted and available for scheduling as expected.
gardener-robot-ci-1
added
reviewed/ok-to-test
aaronfern
reviewed
Jul 18, 2025
gardener-robot-ci-2
added
reviewed/ok-to-test
aaronfern
added
needs/cherry-pick
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot
added
the
status/closed
aaronfern
pushed a commit
to aaronfern/machine-controller-manager
that referenced
this pull request
Jul 18, 2025
* Add taint for critical components not ready after update After a successful in-place update, the controller now adds the 'critical components not ready' taint to the node. This prevents pods from being scheduled until critical component pods are ready, improving node readiness handling. * Remove PreferNoSchedule taint after inplace update After a successful inplace update, the PreferNoSchedule taint is now removed from the node if present. This ensures that nodes are properly untainted and available for scheduling as expected.
aaronfern
added a commit
that referenced
this pull request
Jul 18, 2025
* Add taint for critical components not ready after update After a successful in-place update, the controller now adds the 'critical components not ready' taint to the node. This prevents pods from being scheduled until critical component pods are ready, improving node readiness handling. * Remove PreferNoSchedule taint after inplace update After a successful inplace update, the PreferNoSchedule taint is now removed from the node if present. This ensures that nodes are properly untainted and available for scheduling as expected. Co-authored-by: Sonu Kumar Singh <[email protected]>
This was referenced Aug 29, 2025
This was referenced Aug 29, 2025
This was referenced Sep 4, 2025
This was referenced Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
After a successful in-place update, the controller now adds the 'critical components not ready' taint to the node. This prevents pods from being scheduled until critical component pods are ready, improving node readiness handling.
Which issue(s) this PR fixes:
Part of #944
Special notes for your reviewer:
Release note: