Skip to content

[rel-v0.59] Add taint for critical components not ready after update (#1017) #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aaronfern merged 1 commit into from
Jul 18, 2025
Merged

[rel-v0.59] Add taint for critical components not ready after update (#1017) #1018

aaronfern merged 1 commit into from
Jul 18, 2025

Conversation

@aaronfern
Copy link
Member

@aaronfern aaronfern commented Jul 18, 2025 •
edited
Loading

What this PR does / why we need it:
cherry pick for PR #1017

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

`node.gardener.cloud/critical-components-not-ready` taint is added to the node after the successful in-place update to prevent scheduling any workload before critical component pods are ready.

@acumino @aaronfern
Add taint for critical components not ready after update (gardener#1017)
b4aaf2b 
* Add taint for critical components not ready after update

After a successful in-place update, the controller now adds the 'critical components not ready' taint to the node. This prevents pods from being scheduled until critical component pods are ready, improving node readiness handling.

* Remove PreferNoSchedule taint after inplace update

After a successful inplace update, the PreferNoSchedule taint is now removed from the node if present. This ensures that nodes are properly untainted and available for scheduling as expected.
@aaronfern aaronfern requested a review from a team as a code owner July 18, 2025 10:38
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jul 18, 2025
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 18, 2025
acumino
acumino approved these changes Jul 18, 2025
View reviewed changes
Copy link
Member

@acumino acumino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jul 18, 2025
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 18, 2025
@aaronfern aaronfern merged commit 7a29c87 into gardener:rel-v0.59 Jul 18, 2025
8 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@acumino acumino acumino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aaronfern @acumino @gardener-robot-ci-1 @gardener-robot