Skip to content

[rel-v0.59] Skip machines in InPlaceUpdating phase during machine set transfer to prevent update phase failures #1021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thiyyakat merged 1 commit into from
Jul 23, 2025
Merged

[rel-v0.59] Skip machines in InPlaceUpdating phase during machine set transfer to prevent update phase failures #1021

thiyyakat merged 1 commit into from
Jul 23, 2025

Conversation

@thiyyakat
Copy link
Member

@thiyyakat thiyyakat commented Jul 23, 2025 •
edited
Loading

What this PR does / why we need it:

Cherry-pick of PR #1020

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Fixed a bug where machines in the `InPlaceUpdating` phase were incorrectly transferred to the new machine set during inplace updates. This caused the machine controller to miss updating the phase to `InPlaceUpdateSuccessful`, resulting in machines getting stuck or marked as `InPlaceUpdateFailed`.

@acumino @thiyyakat
Skip machines in InPlaceUpdating phase during machine set transfer …
f0178f6 
…to prevent update phase failures (gardener#1020)

* If machine is in phase `InPlaceUpdating` it should not be moved to new machine set

* Prevent negative value calculation
@thiyyakat thiyyakat requested a review from a team as a code owner July 23, 2025 06:04
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jul 23, 2025
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 23, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 23, 2025
@thiyyakat thiyyakat merged commit 084708a into gardener:rel-v0.59 Jul 23, 2025
8 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aaronfern aaronfern aaronfern approved these changes

Assignees

No one assigned

Labels

needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@thiyyakat @aaronfern @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot @acumino