Skip machines in InPlaceUpdating phase during machine set transfer to prevent update phase failures
#1020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-3
added
needs/ok-to-test
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot
added
the
status/closed
thiyyakat
pushed a commit
to thiyyakat/machine-controller-manager
that referenced
this pull request
Jul 23, 2025
…to prevent update phase failures (gardener#1020) * If machine is in phase `InPlaceUpdating` it should not be moved to new machine set * Prevent negative value calculation
This was referenced Aug 29, 2025
This was referenced Aug 29, 2025
This was referenced Oct 10, 2025
This was referenced Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR updates the
transferMachinesFromOldToNewMachineSetfunction to skip machines in theInPlaceUpdatingphase. This prevents the machine controller from failing to update the phase toInPlaceUpdateSuccessful, which relies on the node having the labelnode.machine.sapcloud.io/update-result. The deployment controller removes this label after a successful update, and the machine is moved to the new machine set, causing the machine phase to get stuck inInPlaceUpdatingand eventually leading to theInPlaceUpdateFailedphase, as the machine controller never gets a chance to update the phase toInPlaceUpdateSuccessful.Which issue(s) this PR fixes:
Part of #944
Special notes for your reviewer:
/invite @aaronfern
Release note: