-
-
Notifications
You must be signed in to change notification settings - Fork 262
[ENH] Implement binary model serialization with compression #1031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Graphite Automations"Add gempy label" took an action on this PR • (05/20/25)1 label was added to this PR based on Miguel de la Varga's automation. |
This was referenced May 22, 2025
4 tasks
Ensure correct `.gempy` extension when saving/loading models, raising errors for invalid or missing extensions. Added automatic creation of directories during save operations. Updated tests to reflect the enforced `.gempy` extension.
Incorporate an optional validation step in `save_model` to ensure correct serialization and deserialization of GeoModels. Added `_validate_serialization` function and updated the workflow to compare model hashes and string representations.
Replaced `SkipValidation` with `Field` for better data validation and structure. Simplified serialization by excluding large data arrays and removed redundant field validators. Updated test references accordingly.
Removed redundant `ColorGenerator` attribute from `StructuralFrame` and streamlined color initialization using default `Field` values. Updated tests accordingly to reflect these changes.
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Description
Implemented a new model serialization system that efficiently saves and loads GeoModel objects to disk. The implementation uses binary serialization with compression to reduce file size while maintaining data integrity.
Key changes:
Relates to #model-serialization
Checklist
or 2. verifies that outputs are as expected for given inputs (e.g. unit tests).