Skip to content

Conversation

@Leguark
Copy link
Member

@Leguark Leguark commented May 22, 2025

Description

This PR fixes a typo in the test function name test_topography_II (previously misspelled as test_topogrphy_II) and adds model serialization verification to this test. It also updates the environment variable paths in the TestStratigraphicPile class to use a base path with PATH_TO_SPREMBERG instead of separate environment variables for each file.

Checklist

  • My code uses type hinting for function and method arguments and return values.
  • I have created tests which cover my code.
  • The test code either 1. demonstrates at least one valuable use case (e.g. integration tests)
    or 2. verifies that outputs are as expected for given inputs (e.g. unit tests).
  • New tests pass locally with my changes.

@Leguark Leguark changed the title [TEST] Fix typo in test name and add model serialization check [BUG] Fix typo in test_topography_II and update Spremberg file paths May 22, 2025
@Leguark Leguark marked this pull request as ready for review May 22, 2025 08:04
@graphite-app graphite-app bot added the gempy 3 Will come with the next major update label May 22, 2025
@graphite-app
Copy link

graphite-app bot commented May 22, 2025

Graphite Automations

"Add gempy label" took an action on this PR • (05/22/25)

1 label was added to this PR based on Miguel de la Varga's automation.

Copy link
Member Author

Leguark commented May 25, 2025

Merge activity

@Leguark Leguark changed the base branch from test_save to graphite-base/1033 May 25, 2025 07:45
Leguark added 3 commits May 25, 2025 07:45
Corrected the test method name from `test_topogrphy_II` to `test_topography_II` for consistency. Added a verification step to validate model serialization after the topography computation.
@graphite-app graphite-app bot changed the base branch from graphite-base/1033 to main May 25, 2025 07:45
Set `scalar_field_at_interface` values and enabled scalar gradient computation. Adjusted function call to disable serialization validation for testing purposes.
@Leguark Leguark merged commit d34e6e2 into main May 25, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gempy 3 Will come with the next major update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants