-
-
Notifications
You must be signed in to change notification settings - Fork 262
[BUG] Fix typo in test_topography_II and update Spremberg file paths #1033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
4 tasks
Graphite Automations"Add gempy label" took an action on this PR • (05/22/25)1 label was added to this PR based on Miguel de la Varga's automation. |
4 tasks
4 tasks
Merge activity
|
Corrected the test method name from `test_topogrphy_II` to `test_topography_II` for consistency. Added a verification step to validate model serialization after the topography computation.
Set `scalar_field_at_interface` values and enabled scalar gradient computation. Adjusted function call to disable serialization validation for testing purposes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Description
This PR fixes a typo in the test function name
test_topography_II(previously misspelled astest_topogrphy_II) and adds model serialization verification to this test. It also updates the environment variable paths in theTestStratigraphicPileclass to use a base path withPATH_TO_SPREMBERGinstead of separate environment variables for each file.Checklist
or 2. verifies that outputs are as expected for given inputs (e.g. unit tests).