Skip to content

[ENH] Add nugget optimization module with per-group optimization capability #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
May 26, 2025
Merged

[ENH] Add nugget optimization module with per-group optimization capability #1036

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
090552a
[WIP] Adding test for nugget effect optimization
Leguark May 25, 2025
2b965af
[WIP] Running nugget optimizer after quite a while
Leguark May 25, 2025
63b6661
[WIP/CLN] Move optimize nugget logic to a module
Leguark May 25, 2025
4c5eef2
[WIP] Improving nugget optimizer
Leguark May 25, 2025
e9911cd
[WIP] Playing with different optimizers
Leguark May 25, 2025
d1efe28
[WIP] Better configuration of parameters
Leguark May 25, 2025
4d8080f
[WIP/CLN] Improve naming
Leguark May 25, 2025
c85d5f6
[ENH] Refactor nugget optimization for modularity and group handling
Leguark May 26, 2025
bbd1c8f
[CLN] Use relative imports in manipulate_points module
Leguark May 26, 2025
6b27207
[CLN/TEST] Cleaning the nugget effect test
Leguark May 26, 2025
5061f77
[BUG] Make sure torch is optional
Leguark May 26, 2025
b5168b6
[TEST] Adding torch to the dev requirements
Leguark May 26, 2025
433db59
[BUG] Remove pyro as gempy dependency
Leguark May 26, 2025
f401319
[BUG] Broken references. I hate python
Leguark May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[CLN/TEST] Cleaning the nugget effect test
  • Loading branch information
@Leguark
Leguark committed May 26, 2025
commit 6b27207f0a136037a5140770911ccfae2ce9cf0d
47 changes: 17 additions & 30 deletions test/test_private/test_terranigma/test_nuggets/test_nugget_effect_optimization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,39 +46,26 @@ def test_optimize_nugget_effect():
topography=(xr.open_dataset(os.path.join(path, "Topography.nc")))
)

if False:
gpv.plot_3d(geo_model, show_data=True, image=True)

geo_model.interpolation_options.cache_mode = gp.data.InterpolationOptions.CacheMode.NO_CACHE
geo_model.interpolation_options.kernel_options.range = 0.5

if True:
gp.API.compute_API.optimize_nuggets(
geo_model=geo_model,
engine_config=gp.data.GemPyEngineConfig(
backend=gp.data.AvailableBackends.PYTORCH,
),
max_epochs=100,
convergence_criteria=1e5,
only_groups=[geo_model.structural_frame.get_group_by_name("Red")]
)
gp.API.compute_API.optimize_nuggets(
geo_model=geo_model,
engine_config=gp.data.GemPyEngineConfig(
backend=gp.data.AvailableBackends.PYTORCH,
),
max_epochs=100,
convergence_criteria=1e5,
only_groups=[geo_model.structural_frame.get_group_by_name("Red")]
)

gp.compute_model(
gempy_model=geo_model,
engine_config=gp.data.GemPyEngineConfig(
backend=gp.data.AvailableBackends.PYTORCH,
),
validate_serialization=False
)
else:
gp.API.compute_API.optimize_and_compute(
geo_model=geo_model,
engine_config=gp.data.GemPyEngineConfig(
backend=gp.data.AvailableBackends.PYTORCH,
),
max_epochs=100,
convergence_criteria=1e5
)
gp.compute_model(
gempy_model=geo_model,
engine_config=gp.data.GemPyEngineConfig(
backend=gp.data.AvailableBackends.PYTORCH,
),
validate_serialization=False
)

print(f"Final cond number: {geo_model.interpolation_options.kernel_options.condition_number}")
nugget_effect = geo_model.taped_interpolation_input.surface_points.nugget_effect_scalar.detach().numpy()
Expand All @@ -96,7 +83,7 @@ def test_optimize_nugget_effect():
import gempy_viewer as gpv
import pyvista as pv

image = False
image = True
gempy_vista = gpv.plot_3d(
model=geo_model,
show=False,
Expand Down