[ENH] Add nugget optimization module with per-group optimization capability #1036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
4 tasks
[CLN] Make modules a bit more clear
Streamlined nugget optimization logic by delegating it to a standalone `run_optimization` function, improving reusability and clarity. Added support for optimizing specific structural groups, enhancing flexibility in nugget effect optimization workflows.
Switched to relative imports for better modularity and cleaner project structure. This change improves maintainability and aligns with Python's best practices for package organization.
Leguark
force-pushed
the
serialize_opt_nugget
branch
from
325dae4 to
6b27207
Compare
Leguark
changed the title
Graphite Automations"Add gempy label" took an action on this PR • (05/26/25)1 label was added to this PR based on Miguel de la Varga's automation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored the nugget optimization functionality into a dedicated module for better organization and reusability. The PR extracts the optimization logic from
compute_API.pyinto a newoptimize_nuggetsmodule with improved structure and cleaner implementation. It also adds a new API functionoptimize_nuggetsthat allows optimizing specific structural groups rather than the entire model.The PR also includes code reorganization, moving the
_LoadDEMArtificialclass fromcreate_topography.pytotopography.pywhere it's more logically placed, and fixing import paths throughout the codebase.Relates to #optimization-refactoring
Checklist
or 2. verifies that outputs are as expected for given inputs (e.g. unit tests).