Skip to content

[ENH] Fix color generator initialization and improve basement color handling #1038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 27, 2025
Merged

[ENH] Fix color generator initialization and improve basement color handling #1038

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
99bfdb7
[ENH] Add default ColorsGenerator and improve condition handling
Leguark May 26, 2025
39e7b2e
[ENH] Ensure unique basement color and improve serialization
Leguark May 26, 2025
d10218d
[TEST] Updated approved files
Leguark May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[TEST] Updated approved files
  • Loading branch information
@Leguark
Leguark committed May 27, 2025
commit d10218d1c94b821a7e2c3208111cc1dfc72ac199
5 changes: 4 additions & 1 deletion ...test_modules/_geophysics_TO_UPDATE/test_gravity.test_gravity.verify/2-layers.approved.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,11 @@
"solution": null
}
],
"is_dirty": true,
"color_generator": {
"_index": 3
},
"basement_color": "#ffbe00",
"is_dirty": true,
"binary_meta_data": {
"sp_binary_length": 144,
"ori_binary_length": 60
Expand Down
5 changes: 4 additions & 1 deletion ...ults/test_finite_faults.test_finite_fault_scalar_field_on_fault.verify/fault.approved.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,11 @@
"solution": null
}
],
"is_dirty": true,
"color_generator": {
"_index": 4
},
"basement_color": "#728f02",
"is_dirty": true,
"binary_meta_data": {
"sp_binary_length": 792,
"ori_binary_length": 300
Expand Down
5 changes: 4 additions & 1 deletion test/test_modules/test_grids/test_custom_grid.test_custom_grid.verify/fold.approved.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,11 @@
"solution": null
}
],
"is_dirty": true,
"color_generator": {
"_index": 3
},
"basement_color": "#ffbe00",
"is_dirty": true,
"binary_meta_data": {
"sp_binary_length": 1296,
"ori_binary_length": 120
Expand Down
5 changes: 4 additions & 1 deletion test/test_modules/test_grids/test_grids_sections.test_section_grids.verify/fold.approved.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,11 @@
"solution": null
}
],
"is_dirty": true,
"color_generator": {
"_index": 3
},
"basement_color": "#ffbe00",
"is_dirty": true,
"binary_meta_data": {
"sp_binary_length": 1296,
"ori_binary_length": 120
Expand Down
11 changes: 7 additions & 4 deletions ...test_modules/test_grids/test_grids_sections.test_topography_II.verify/Model1.approved.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
{
"name": "fault1",
"is_active": true,
"_color": "#728f02",
"_color": "#443988",
"surface_points": {
"name_id_map": {
"fault1": 26244822
Expand Down Expand Up @@ -56,7 +56,7 @@
{
"name": "surface2",
"is_active": true,
"_color": "#9f0052",
"_color": "#ffbe00",
"surface_points": {
"name_id_map": {
"surface2": 21816406
Expand All @@ -73,7 +73,7 @@
{
"name": "surface3",
"is_active": true,
"_color": "#ffbe00",
"_color": "#728f02",
"surface_points": {
"name_id_map": {
"surface3": 98435767
Expand All @@ -94,8 +94,11 @@
"solution": null
}
],
"color_generator": {
"_index": 5
},
"basement_color": "#9f0052",
"is_dirty": true,
"basement_color": "#443988",
"binary_meta_data": {
"sp_binary_length": 360,
"ori_binary_length": 120
Expand Down
2 changes: 1 addition & 1 deletion ...ntal_stratigraphic_model.verify/Horizontal Stratigraphic Model serialization.approved.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
}
],
"color_generator": {
"_index": 2
"_index": 3
},
"basement_color": "#ffbe00",
"is_dirty": true,
Expand Down