[ENH] Fix color generator initialization and improve basement color handling #1038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
4 tasks
Leguark
force-pushed
the
serialize_opt_nugget
branch
from
325dae4 to
6b27207
Compare
Leguark
force-pushed
the
fixed_serialization
branch
from
512780d to
d26687b
Compare
Leguark
changed the title
Graphite Automations"Add gempy label" took an action on this PR • (05/26/25)1 label was added to this PR based on Miguel de la Varga's automation. |
Leguark
force-pushed
the
fixed_serialization
branch
from
d26687b to
ae311a2
Compare
Leguark
force-pushed
the
fixed_serialization
branch
3 times, most recently
from
04d5d3a to
ed7aa1a
Compare
Introduce `Field(default_factory=ColorsGenerator)` to `StructuralFrame` for streamlined initialization. Convert condition number to numpy array in optimization logic for compatibility. Minor adjustments made for improved model validation and notes added for future enhancements.
Introduce a method to allocate a unique basement color, avoiding duplication among structural elements. Minor enhancements include improved serialization output and cleanup of redundant or commented-out code.
Leguark
force-pushed
the
fixed_serialization
branch
from
ed7aa1a to
9c0d434
Compare
Leguark
force-pushed
the
fixed_serialization
branch
from
9c0d434 to
d10218d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the
ColorsGeneratorclass to use__post_init__instead of__init__and improves the basement color generation inStructuralFrame. The changes include:ColorsGeneratorto use__post_init__for proper dataclass initializationcolor_generatoras a proper field with default factory inStructuralFrameRelates to #optimization-and-refactoring
Checklist