Skip to content

Display snackbar in geoshape/trace when automatic location recording is used#7037

Merged
seadowg merged 2 commits intogetodk:masterfrom
grzesiek2010:COLLECT-7036
Jan 21, 2026
Merged

Display snackbar in geoshape/trace when automatic location recording is used#7037
seadowg merged 2 commits intogetodk:masterfrom
grzesiek2010:COLLECT-7036

Conversation

@grzesiek2010
Copy link
Copy Markdown
Member

@grzesiek2010 grzesiek2010 commented Jan 20, 2026

Closes #7036

Why is this the best possible solution? Were any other approaches considered?

We used to call #setChangeResult separately for each case (adding points manually, removing them, dragging, etc.). This was error-prone, as it could be missed in some scenarios, which is what caused this issue. Instead, we should call it whenever the list of points is updated.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

It should simply fix te issue.

Do we need any specific form for testing your changes? If so, please attach one.

The form is linked in the issue.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@grzesiek2010 grzesiek2010 requested a review from seadowg January 20, 2026 22:47
@seadowg seadowg merged commit f02792d into getodk:master Jan 21, 2026
7 checks passed
@dbemke
Copy link
Copy Markdown

dbemke commented Jan 22, 2026

Tested with success

Verified on device with Android 10

Verified cases:

@srujner
Copy link
Copy Markdown

srujner commented Jan 22, 2026

Tested with success

Verified on device with Android 12

@WKobus
Copy link
Copy Markdown

WKobus commented Jan 22, 2026

Tested with success

Verified on device with Android 16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No snackbar in geoshape/trace when automatic location recording is used

5 participants