Skip to content

Display snackbar in geoshape/trace when automatic location recording is used #7037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seadowg merged 2 commits into from
Jan 21, 2026
Merged

Display snackbar in geoshape/trace when automatic location recording is used #7037

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34f1a6c
Add failing test
grzesiek2010 Jan 20, 2026
01c2cc8
Call #setChangeResult whenever points are updated
grzesiek2010 Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Call #setChangeResult whenever points are updated
  • Loading branch information
@grzesiek2010
grzesiek2010 committed Jan 20, 2026
commit 01c2cc823ec0b2712cdae1f4746a8ec8e560b7c2
6 changes: 1 addition & 5 deletions geo/src/main/java/org/odk/collect/geo/geopoly/GeoPolyFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,6 @@ class GeoPolyFragment @JvmOverloads constructor(
map!!.setRetainMockAccuracy(retainMockAccuracy)
map!!.setDragEndListener {
viewModel.update(map!!.getPolyPoints(it))
setChangeResult()
}

if (!map!!.hasCenter()) {
Expand Down Expand Up @@ -280,6 +279,7 @@ class GeoPolyFragment @JvmOverloads constructor(
}

updateUi()
setChangeResult()
}
}

Expand Down Expand Up @@ -395,7 +395,6 @@ class GeoPolyFragment @JvmOverloads constructor(
private fun onClick(point: MapPoint) {
if (inputActive && !recordingEnabled) {
viewModel.add(point)
setChangeResult()
}
}

Expand All @@ -417,7 +416,6 @@ class GeoPolyFragment @JvmOverloads constructor(
private fun recordPoint(point: MapPoint?) {
if (point != null && isLocationAcceptable(point)) {
viewModel.add(point)
setChangeResult()
}
}

Expand All @@ -438,14 +436,12 @@ class GeoPolyFragment @JvmOverloads constructor(
private fun removeLastPoint() {
if (featureId != -1) {
viewModel.removeLast()
setChangeResult()
}
}

private fun clear() {
inputActive = false
viewModel.update(emptyList())
setChangeResult()
}

/** Updates the state of various UI widgets to reflect internal state. */
Expand Down