fix: Support importlib_metadata v5.0.0 #5840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
importlib_metadata removed compatibility shims for deprecated entry point interfaces. see: https://github.com/python/importlib_metadata/blob/main/CHANGES.rst#v500 Filter result of entry_points function by group parameter. see: https://importlib-metadata.readthedocs.io/en/latest/api.html#importlib_metadata.entry_points
tsbkw
force-pushed
the
support-importlib_meta-v5.0.0
branch
2 times, most recently
from
e7cdc49 to
ed4b893
Compare
In circleci frontend-unit-tests, old node image is used and python 3.5 is used. Support both old version and latest version by checking ijmportlib_metadata version
tsbkw
force-pushed
the
support-importlib_meta-v5.0.0
branch
from
ed4b893 to
1a525b9
Compare
Member
|
@susodapop ping |
Contributor
|
@susodapop could you please merge this one? |
Member
|
This one seems like the better approach, rather than #5831. @susodapop I'm inclined to merge this, if you have no objections? |
|
i want this!! |
Member
|
@justinclift one month has passed :( |
Contributor
|
I've written elsewhere in the repo issues and PR's that I'm not actively contributing to Redash at the moment. Best to ping @arikfr |
Member
|
@susodapop Ahhh, sorry. Was on leave, and missed that. I'll merge this pro-actively for now, and if it causes issues we can investigate/fix them over time. Hmm, on that note I saw some Cypress problems recently, but haven't looked into them at all. Something to add to the ToDo list. 😉 |
This was referenced Feb 16, 2023
AkaashK
pushed a commit
to tharzeez/redash
that referenced
this pull request
Jul 18, 2023
* fix: Support importlib_metadata v5.0.0 importlib_metadata removed compatibility shims for deprecated entry point interfaces. see: https://github.com/python/importlib_metadata/blob/main/CHANGES.rst#v500 Filter result of entry_points function by group parameter. see: https://importlib-metadata.readthedocs.io/en/latest/api.html#importlib_metadata.entry_points * fix: Enable to run in older python version In circleci frontend-unit-tests, old node image is used and python 3.5 is used. Support both old version and latest version by checking ijmportlib_metadata version
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Jan 8, 2025
* fix: Support importlib_metadata v5.0.0 importlib_metadata removed compatibility shims for deprecated entry point interfaces. see: https://github.com/python/importlib_metadata/blob/main/CHANGES.rst#v500 Filter result of entry_points function by group parameter. see: https://importlib-metadata.readthedocs.io/en/latest/api.html#importlib_metadata.entry_points * fix: Enable to run in older python version In circleci frontend-unit-tests, old node image is used and python 3.5 is used. Support both old version and latest version by checking ijmportlib_metadata version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
importlib_metadata removed compatibility shims for deprecated entry point interfaces.
see: https://github.com/python/importlib_metadata/blob/main/CHANGES.rst#v500
Filter result of entry_points function by group parameter.
see: https://importlib-metadata.readthedocs.io/en/latest/api.html#importlib_metadata.entry_points
It seems #5831 fix problem by using old version, but supporting new version should be encouraged.
redash support Nodejs v14.17 and test frontend in circleci with circleci/node:14.17.
This include old python v3.5 and require some dirty hack. 034fcc2
If changing image used in circleci is better, I prefer to handle it in another pull request.
How is this tested?
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
percy in CI is failed but it is caused by #5691 and it seems OK.