Skip to content

test(rrweb): Re-enable skipped test #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2024
Merged

test(rrweb): Re-enable skipped test #229

merged 1 commit into from
Dec 18, 2024

Conversation

@billyvg
Copy link
Member

@billyvg billyvg commented Dec 13, 2024

Re-enables test that was skipped in #172;

@billyvg
test(rrweb): Re-enable skipped test
ae61ee3 
Re-enables test that was skipped in #172;
@billyvg
Copy link
Member Author

billyvg commented Dec 13, 2024

Closes #172

@billyvg billyvg marked this pull request as ready for review December 13, 2024 18:22
@billyvg billyvg requested review from a team and removed request for a team December 13, 2024 18:22
c298lee
c298lee reviewed Dec 13, 2024
View reviewed changes
Copy link

@c298lee c298lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 is it no longer flakey anymore?

@billyvg
Copy link
Member Author

billyvg commented Dec 13, 2024 •
edited
Loading

I re-ran the test 3 times so far -- will run it a few more times

edit ran 10+ times

@billyvg billyvg merged commit dd1f591 into sentry-v2 Dec 18, 2024
16 checks passed
@billyvg billyvg deleted the fix-rrweb-reenable-cross-origin-test branch December 18, 2024 16:23
@billyvg billyvg mentioned this pull request Jan 7, 2025
Closed
billyvg added a commit that referenced this pull request Jan 10, 2025
@billyvg
test(rrweb): Re-enable skipped test (#229)
d5cbc97 
Re-enables test that was skipped in
#172;
billyvg added a commit that referenced this pull request Jan 14, 2025
@billyvg
test(rrweb): Re-enable skipped test (#229)
671c53f 
Re-enables test that was skipped in
#172;
billyvg added a commit that referenced this pull request Jan 14, 2025
@billyvg
test(rrweb): Re-enable skipped test (#229)
4d840b6 
Re-enables test that was skipped in
#172;
billyvg added a commit that referenced this pull request Jan 23, 2025
@billyvg
test(rrweb): Re-enable skipped test (#229)
441c6fe 
Re-enables test that was skipped in
#172;
@c298lee c298lee mentioned this pull request Feb 18, 2025
Merged
billyvg pushed a commit to getsentry/sentry-javascript that referenced this pull request Feb 24, 2025
@c298lee
feat(replay): Update rrweb packages to 2.32.0 (#15443)
4c54bed 
Includes the following:

- getsentry/rrweb#239
- getsentry/rrweb#237
- getsentry/rrweb#238
- getsentry/rrweb#234
- rrweb-io/rrweb#1501
- rrweb-io/rrweb#1500
- rrweb-io/rrweb#1033
- getsentry/rrweb#233
- getsentry/rrweb#229
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@c298lee c298lee c298lee approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@billyvg @c298lee