Skip to content

test(rrweb): Re-enable skipped test #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2024
Merged

test(rrweb): Re-enable skipped test #229

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test(rrweb): Re-enable skipped test 
Re-enables test that was skipped in #172;
  • Loading branch information
@billyvg
billyvg committed Dec 13, 2024
commit ae61ee38ead0daeb673ff3705842ea55b6b22713
3 changes: 1 addition & 2 deletions packages/rrweb/test/record/cross-origin-iframes.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,8 +205,7 @@ describe('cross origin iframes', function (this: ISuite) {
).not.toBe(1);
});

// This test is quite flakey in CI
it.skip('should replace the existing DOM nodes on iframe navigation with `isAttachIframe`', async () => {
it('should replace the existing DOM nodes on iframe navigation with `isAttachIframe`', async () => {
await ctx.page.evaluate((url) => {
const iframe = document.querySelector('iframe') as HTMLIFrameElement;
iframe.src = `${url}/html/form.html?2`;
Expand Down
Loading