This repository was archived by the owner on Aug 30, 2023. It is now read-only.
feat: publish to bintray #121
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-garcia
commented
Nov 9, 2019
|
|
||
| plugins { | ||
| `java-library` | ||
| `maven-publish` |
Member
Author
There was a problem hiding this comment.
@marandaneto I guess merging #70 will affect this bit
marandaneto
reviewed
Nov 10, 2019
| publications { | ||
| register(project.name, MavenPublication::class) { | ||
| if (project.hasProperty("android")) { | ||
| artifact("$buildDir/outputs/aar/${project.name}-release.aar") |
Contributor
There was a problem hiding this comment.
this is the sentry-core module, we don't need android stuff in here
Member
Author
There was a problem hiding this comment.
Right, this is all very provisional. It will all move to the main gradle file
marandaneto
reviewed
Nov 10, 2019
| id("com.android.application") | ||
| kotlin("android") | ||
| // id("io.sentry.android.gradle") how to add sentry gradle plugin | ||
| id(Config.PublishPlugins.bintrayPlugin) |
Contributor
There was a problem hiding this comment.
this should go into the modules that would be published, not in the sample app.
Member
Author
There was a problem hiding this comment.
right, just playing around. Draft PR
Member
Author
There was a problem hiding this comment.
I'll add a description of the goal
Member
Author
|
Closed in favor of #129 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing this I found we have to publish snapshot builds to artifactory instead.
The goal of this PR is to be able to publish packages via the main gradle file which will publish jar for sentry-core and arr for the Android libraries. It'll also ignore the sample project.