WIP - publish maven local #70
Conversation
bruno-garcia
left a comment
bruno-garcia
left a comment
There was a problem hiding this comment.
LGTM but CI isn't happy yet
NDK not configured. Download it with SDK manager. Preferred NDK version is '20.0.5594570' maybe because it's still beta?! |
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
============================================
+ Coverage 57.24% 57.79% +0.55%
- Complexity 494 513 +19
============================================
Files 70 70
Lines 2313 2353 +40
Branches 207 221 +14
============================================
+ Hits 1324 1360 +36
- Misses 897 901 +4
Partials 92 92
Continue to review full report at Codecov.
|
|
|
||
| # Migrating to AndroidX - AGP 3.6.x | ||
| android.useAndroidX=true | ||
| #android.enableJetifier=true - causing SHA1 digest error |
There was a problem hiding this comment.
similar issue AzureAD/microsoft-authentication-library-for-android#455
|
|
||
| object BuildPlugins { | ||
| val androidGradle = "com.android.tools.build:gradle:3.5.2" | ||
| val androidGradle = "com.android.tools.build:gradle:3.6.0-beta03" |
There was a problem hiding this comment.
@ninniuz what do you think about that?
I'd like to use maven-publish with the native support that AGP 3.6.x provides.
There was a problem hiding this comment.
It is a great addition to AGP and it makes publishing a lot easier, but I wouldn't use beta releases as they could affect aar generation.
There was a problem hiding this comment.
@ninniuz based on the changelog, the "only" different thing that affects aar generation would be useNewApkCreator which I've disabled, that's why I think it's safe to go, but I do understand your concern.
| api(project(":sentry-android-ndk")) | ||
| } | ||
|
|
||
| afterEvaluate { |
There was a problem hiding this comment.
Can you factor out the repeated publishing logic into the main build.gradle file?
|
for now in favor of #129 |
|
using https://github.com/novoda/bintray-release for now |
📢 Type of change
📜 Description
publish artifacts to maven local
💡 Motivation and Context
for testing the SDK as a maven dependency
💚 How did you test it?
App. sample implements the maven artifact.
How to publish:
./gradlew publishReleasePublicationToMavenLocal
📝 Checklist
🔮 Next steps
add javadocs to maven as well