Skip to content
This repository was archived by the owner on Aug 30, 2023. It is now read-only.

Conversation

@marandaneto
Copy link
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

🔮 Next steps

@codecov-io
Copy link

codecov-io commented Oct 24, 2019

Codecov Report

Merging #61 into master will increase coverage by 4.16%.
The diff coverage is 81.17%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #61      +/-   ##
============================================
+ Coverage     44.62%   48.79%   +4.16%     
- Complexity      243      281      +38     
============================================
  Files            52       56       +4     
  Lines          1443     1494      +51     
  Branches         90       94       +4     
============================================
+ Hits            644      729      +85     
+ Misses          767      730      -37     
- Partials         32       35       +3
Impacted Files Coverage Δ Complexity Δ
...java/io/sentry/core/protocol/SentryStackTrace.java 77.77% <ø> (+33.33%) 4 <0> (+2) ⬆️
...ore/src/main/java/io/sentry/core/SentryClient.java 81.08% <ø> (+6.08%) 11 <0> (-1) ⬇️
...core/src/main/java/io/sentry/core/SentryEvent.java 30.58% <0%> (+2.49%) 13 <0> (+1) ⬆️
.../main/java/io/sentry/core/SentryThreadFactory.java 100% <100%> (ø) 10 <0> (-3) ⬇️
...n/java/io/sentry/core/SentryStackTraceFactory.java 100% <100%> (ø) 4 <4> (?)
...re/src/main/java/io/sentry/core/SentryOptions.java 78.68% <100%> (+0.35%) 29 <0> (ø) ⬇️
...ry/core/exception/ExceptionMechanismThrowable.java 100% <100%> (ø) 3 <3> (?)
...java/io/sentry/core/protocol/SentryStackFrame.java 28.07% <20%> (+8.77%) 11 <2> (+5) ⬆️
...c/main/java/io/sentry/core/MainEventProcessor.java 81.25% <81.25%> (ø) 4 <4> (?)
...in/java/io/sentry/core/SentryExceptionFactory.java 91.66% <91.66%> (ø) 7 <7> (?)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d2096b...a7ff3aa. Read the comment docs.

@marandaneto marandaneto changed the title WIP - stacktraces stacktraces Oct 25, 2019
@marandaneto marandaneto changed the title stacktraces feat stacktraces and exceptions Oct 25, 2019
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, just left one nit for a test

@bruno-garcia bruno-garcia merged commit 8d03bb7 into master Oct 27, 2019
@bruno-garcia bruno-garcia deleted the feat/stacktraces branch October 27, 2019 20:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants