This repository was archived by the owner on Aug 30, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 30
feat stacktraces and exceptions #61
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
commented
Oct 24, 2019
Codecov Report
@@ Coverage Diff @@
## master #61 +/- ##
============================================
+ Coverage 44.62% 48.79% +4.16%
- Complexity 243 281 +38
============================================
Files 52 56 +4
Lines 1443 1494 +51
Branches 90 94 +4
============================================
+ Hits 644 729 +85
+ Misses 767 730 -37
- Partials 32 35 +3
Continue to review full report at Codecov.
|
marandaneto
commented
Oct 24, 2019
sentry-core/src/main/java/io/sentry/core/exception/SentryExceptionReader.java
Outdated
Show resolved
Hide resolved
marandaneto
commented
Oct 24, 2019
sentry-core/src/main/java/io/sentry/core/exception/SentryExceptionReader.java
Outdated
Show resolved
Hide resolved
marandaneto
commented
Oct 24, 2019
sentry-core/src/main/java/io/sentry/core/exception/SentryExceptionReader.java
Outdated
Show resolved
Hide resolved
marandaneto
commented
Oct 24, 2019
sentry-core/src/main/java/io/sentry/core/exception/SentryExceptionReader.java
Outdated
Show resolved
Hide resolved
sentry-core/src/main/java/io/sentry/core/exception/SentryFrame.java
Outdated
Show resolved
Hide resolved
sentry-core/src/main/java/io/sentry/core/exception/SentryStackFrameReader.java
Outdated
Show resolved
Hide resolved
bruno-garcia
suggested changes
Oct 24, 2019
sentry-android-core/src/main/java/io/sentry/android/core/AndroidOptionsInitializer.java
Outdated
Show resolved
Hide resolved
sentry-core/src/main/java/io/sentry/core/exception/SentryExceptionReader.java
Outdated
Show resolved
Hide resolved
sentry-core/src/main/java/io/sentry/core/exception/SentryExceptionReader.java
Outdated
Show resolved
Hide resolved
sentry-core/src/main/java/io/sentry/core/exception/SentryFrame.java
Outdated
Show resolved
Hide resolved
sentry-core/src/main/java/io/sentry/core/exception/SentryStackFrameReader.java
Outdated
Show resolved
Hide resolved
bruno-garcia
approved these changes
Oct 25, 2019
bruno-garcia
approved these changes
Oct 27, 2019
Member
bruno-garcia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, just left one nit for a test
sentry-core/src/test/java/io/sentry/core/SentryStackTraceFactoryTest.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
🔮 Next steps