WIP

sentry-core/src/main/java/io/sentry/core/MainEventProcessor.java

@@ -26,9 +26,6 @@ public SentryEvent process(SentryEvent event) {
         event.setMessage(getMessage(throwable));
       }
 
-//      List<SentryException> exceptions = new ArrayList<>();
-//      exceptions.add(extractExceptionQueue(event.getThrowable()));
-//      event.setException(exceptions);
       event.setException(SentryExceptionReader.sentryExceptionReader(throwable));
     }
 
@@ -40,26 +37,4 @@ private Message getMessage(Throwable throwable) {
     message.setFormatted(throwable.getMessage());
     return message;
   }
-
-  private SentryException extractExceptionQueue(Throwable throwable) {
-    //    throwable.
-
-    SentryException sentryException = new SentryException();
-    SentryStackTrace sentryStackTrace = new SentryStackTrace();
-    List<SentryStackFrame> frames = new ArrayList<>();
-
-    for (StackTraceElement stackTraceElement : throwable.getStackTrace()) {
-      SentryStackFrame stackFrame = new SentryStackFrame();
-      stackFrame.setFunction(stackTraceElement.getMethodName());
-      stackFrame.setModule(stackTraceElement.getClassName());
-      stackFrame.setFilename(stackTraceElement.getFileName());
-      stackFrame.setLineno(stackTraceElement.getLineNumber());
-
-      frames.add(stackFrame);
-    }
-    sentryStackTrace.setFrames(frames);
-    sentryException.setStacktrace(sentryStackTrace);
-
-    return sentryException;
-  }
 }

sentry-core/src/main/java/io/sentry/core/exception/SentryExceptionReader.java

@@ -12,7 +12,7 @@
 import java.util.List;
 import java.util.Set;
 
-public class SentryExceptionReader {
+public final class SentryExceptionReader {
 
   /**
    * Creates a new instance from the given {@code throwable}.
@@ -45,7 +45,7 @@ private static List<SentryException> sentryExceptionReader(final Deque<SentryExc
    */
   private static SentryException sentryExceptionReader(
     Throwable throwable,
-    StackTraceElement[] childExceptionStackTrace,
+    StackTraceElement[] childExceptionStackTrace, // TODO: do we need that?
     Mechanism exceptionMechanism) {
 
     Package exceptionPackage = throwable.getClass().getPackage();
@@ -63,18 +63,14 @@ private static SentryException sentryExceptionReader(
       : null;
     // TODO: whats about those missing fields? message, classname, packagename, ...
 
-//    StackTraceReader stackTraceInterface = new StackTraceReader(
-//      throwable.getStackTrace(),
-//      childExceptionStackTrace,
-//      FrameCache.get(throwable));
     SentryStackTrace sentryStackTrace = new SentryStackTrace();
     sentryStackTrace.setFrames(
       Arrays.asList(SentryStackFrameReader.fromStackTraceElements(
         throwable.getStackTrace(), null))); // TODO: cached frames
 
-//    SentryStackTrace sentryStackTrace = new SentryStackTrace();
     exception.setStacktrace(sentryStackTrace);
     exception.setType("ValueError"); // TODO ?
+//    exception.setValue(); type or value is mandatory
 
     exception.setMechanism(exceptionMechanism);
     return exception;

sentry-core/src/main/java/io/sentry/core/exception/SentryFrame.java

@@ -5,6 +5,7 @@
 import java.util.HashMap;
 import java.util.Map;
 
+// TODO: should we use that? why?
 public class SentryFrame {
   /**
    * Method that this frame originated in.

sentry-core/src/main/java/io/sentry/core/exception/SentryStackFrameReader.java

@@ -4,7 +4,7 @@
 
 import java.util.Map;
 
-public class SentryStackFrameReader {
+public final class SentryStackFrameReader {
 
   /**
    * Convert an array of {@link StackTraceElement}s to {@link SentryStackFrame}s.