Skip to content
This repository was archived by the owner on Aug 30, 2023. It is now read-only.

Conversation

@marandaneto
Copy link
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

added the missing fields of the protocol.

💡 Motivation and Context

there were a few missing fields

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

🔮 Next steps

public class SentryStackTrace implements IUnknownPropertiesConsumer {
private List<SentryStackFrame> frames;
// TODO registers is missing?
private Map<String, String> registers;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bruno-garcia is it a Map?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it: https://docs.sentry.io/development/sdk-dev/event-payloads/stacktrace/#attributes

 registers:

    Optional. A map of register names and their values. The values should contain the actual register values of the thread, thus mapping to the last frame in the list.

@codecov-io
Copy link

codecov-io commented Oct 28, 2019

Codecov Report

Merging #71 into master will decrease coverage by 0.36%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #71      +/-   ##
============================================
- Coverage     48.84%   48.47%   -0.37%     
  Complexity      340      340              
============================================
  Files            59       59              
  Lines          1730     1743      +13     
  Branches        134      134              
============================================
  Hits            845      845              
- Misses          836      849      +13     
  Partials         49       49
Impacted Files Coverage Δ Complexity Δ
...re/src/main/java/io/sentry/core/protocol/User.java 38.88% <ø> (ø) 5 <0> (ø) ⬇️
...entry-core/src/main/java/io/sentry/core/Scope.java 81.25% <ø> (ø) 15 <0> (ø) ⬇️
...src/main/java/io/sentry/core/protocol/Request.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...c/main/java/io/sentry/core/MainEventProcessor.java 81.25% <0%> (ø) 4 <0> (ø) ⬇️
...core/src/main/java/io/sentry/core/SentryEvent.java 54.16% <0%> (-1.75%) 30 <0> (ø)
.../main/java/io/sentry/core/protocol/SdkVersion.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...java/io/sentry/core/protocol/SentryStackTrace.java 58.33% <0%> (-19.45%) 4 <0> (ø)
...java/io/sentry/core/protocol/SentryStackFrame.java 26.66% <0%> (-1.41%) 11 <0> (ø)
...ore/src/main/java/io/sentry/core/SentryClient.java 86.88% <100%> (ø) 22 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10059f8...c5101df. Read the comment docs.

}

public void setFingerprint(List<String> fingerprint) {
public void setFingerprints(List<String> fingerprint) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public void setFingerprints(List<String> fingerprint) {
public void setFingerprint(List<String> fingerprint) {

@bruno-garcia bruno-garcia merged commit 1596e81 into master Oct 28, 2019
@bruno-garcia bruno-garcia deleted the feat/missing_fields_protocol branch October 28, 2019 19:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants