-
-
Notifications
You must be signed in to change notification settings - Fork 30
added missing protocol fields #71
Conversation
| public class SentryStackTrace implements IUnknownPropertiesConsumer { | ||
| private List<SentryStackFrame> frames; | ||
| // TODO registers is missing? | ||
| private Map<String, String> registers; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bruno-garcia is it a Map?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it: https://docs.sentry.io/development/sdk-dev/event-payloads/stacktrace/#attributes
registers:
Optional. A map of register names and their values. The values should contain the actual register values of the thread, thus mapping to the last frame in the list.
Codecov Report
@@ Coverage Diff @@
## master #71 +/- ##
============================================
- Coverage 48.84% 48.47% -0.37%
Complexity 340 340
============================================
Files 59 59
Lines 1730 1743 +13
Branches 134 134
============================================
Hits 845 845
- Misses 836 849 +13
Partials 49 49
Continue to review full report at Codecov.
|
| } | ||
|
|
||
| public void setFingerprint(List<String> fingerprint) { | ||
| public void setFingerprints(List<String> fingerprint) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| public void setFingerprints(List<String> fingerprint) { | |
| public void setFingerprint(List<String> fingerprint) { |
📢 Type of change
📜 Description
added the missing fields of the protocol.
💡 Motivation and Context
there were a few missing fields
💚 How did you test it?
📝 Checklist
🔮 Next steps