This repository was archived by the owner on Aug 30, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 30
added missing protocol fields #71
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -40,11 +40,11 @@ public void setUser(User user) { | |||||
| this.user = user; | ||||||
| } | ||||||
|
|
||||||
| public List<String> getFingerprint() { | ||||||
| public List<String> getFingerprints() { | ||||||
| return fingerprint; | ||||||
| } | ||||||
|
|
||||||
| public void setFingerprint(List<String> fingerprint) { | ||||||
| public void setFingerprints(List<String> fingerprint) { | ||||||
|
||||||
| public void setFingerprints(List<String> fingerprint) { | |
| public void setFingerprint(List<String> fingerprint) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,7 +7,7 @@ | |
| /** The Sentry stacktrace. */ | ||
| public class SentryStackTrace implements IUnknownPropertiesConsumer { | ||
| private List<SentryStackFrame> frames; | ||
| // TODO registers is missing? | ||
| private Map<String, String> registers; | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @bruno-garcia is it a
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like it: https://docs.sentry.io/development/sdk-dev/event-payloads/stacktrace/#attributes |
||
| private Map<String, Object> unknown; | ||
|
|
||
| public SentryStackTrace() {} | ||
|
|
@@ -37,4 +37,12 @@ public void setFrames(List<SentryStackFrame> frames) { | |
| public void acceptUnknownProperties(Map<String, Object> unknown) { | ||
| this.unknown = unknown; | ||
| } | ||
|
|
||
| public Map<String, String> getRegisters() { | ||
| return registers; | ||
| } | ||
|
|
||
| public void setRegisters(Map<String, String> registers) { | ||
| this.registers = registers; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,13 +13,13 @@ class HubTest { | |
| @Test | ||
| fun `when cloning Scope it returns the same values`() { | ||
| val scope = Scope() | ||
| scope.extra["test"] = "test" | ||
| scope.extras["test"] = "test" | ||
| val breadcrumb = Breadcrumb() | ||
| breadcrumb.message = "test" | ||
| scope.breadcrumbs.add(breadcrumb) | ||
| scope.level = SentryLevel.DEBUG | ||
| scope.transaction = "test" | ||
| scope.fingerprint.add("test") | ||
| scope.fingerprints.add("test") | ||
| scope.tags["test"] = "test" | ||
| val user = User() | ||
| user.email = "[email protected]" | ||
|
|
@@ -28,10 +28,10 @@ class HubTest { | |
| val clone = scope.clone() | ||
| assertNotNull(clone) | ||
| assertNotSame(scope, clone) | ||
| assertEquals("test", clone.extra["test"]) | ||
| assertEquals("test", clone.extras["test"]) | ||
| assertEquals("test", clone.breadcrumbs[0].message) | ||
| assertEquals("test", scope.transaction) | ||
| assertEquals("test", scope.fingerprint[0]) | ||
| assertEquals("test", scope.fingerprints[0]) | ||
| assertEquals("test", clone.tags["test"]) | ||
| assertEquals("[email protected]", clone.user.email) | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.