Skip to content

ref: Hub passes the Scope #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marandaneto merged 17 commits into from
Oct 20, 2020
Merged

ref: Hub passes the Scope #114

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
8c6727d
init has a private method
marandaneto Oct 19, 2020
7570846
fix merge
marandaneto Oct 19, 2020
c1033b2
draft
marandaneto Oct 19, 2020
c3f453a
fix test
marandaneto Oct 19, 2020
a46e144
hub passes scope to client
marandaneto Oct 19, 2020
8a14620
fix
marandaneto Oct 19, 2020
4c3f323
fix broken tests
marandaneto Oct 19, 2020
35e3072
changelog
marandaneto Oct 19, 2020
30fa7a9
ignore omit_local_variable_types
marandaneto Oct 20, 2020
9088c88
ref
marandaneto Oct 20, 2020
e93f85e
ref imports
marandaneto Oct 20, 2020
7b05b0b
Update dart/lib/src/hub.dart
marandaneto Oct 20, 2020
1f70e4f
Update dart/lib/src/noop_hub.dart
marandaneto Oct 20, 2020
1f4bb44
Merge branch 'ref/hub-pass-scope' of github.com:getsentry/sentry-dart…
marandaneto Oct 20, 2020
d4334a9
ref
marandaneto Oct 20, 2020
d02947f
fix dartfmt
marandaneto Oct 20, 2020
ba721bd
fix merge conflict
marandaneto Oct 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix
  • Loading branch information
@marandaneto
marandaneto committed Oct 19, 2020
commit 8a1462056780ba90b2de4bed2810fd43831392d4
4 changes: 3 additions & 1 deletion dart/lib/src/noop_client.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import 'package:http/src/client.dart';

import 'client.dart';
import 'protocol.dart';
import 'scope.dart';

class NoOpSentryClient implements SentryClient {
NoOpSentryClient._();
Expand Down Expand Up @@ -32,7 +33,7 @@ class NoOpSentryClient implements SentryClient {
Future.value(SentryId.empty());

@override
Future<SentryId> captureException(throwable, {stackTrace}) =>
Future<SentryId> captureException(throwable, {stackTrace, scope}) =>
Future.value(SentryId.empty());

@override
Expand All @@ -41,6 +42,7 @@ class NoOpSentryClient implements SentryClient {
SeverityLevel level = SeverityLevel.info,
String template,
List<dynamic> params,
Scope scope,
}) =>
Future.value(SentryId.empty());

Expand Down
4 changes: 2 additions & 2 deletions dart/test/test_utils.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,13 +106,13 @@ Future testCaptureException(
} else {
data = json.decode(utf8.decode(body)) as Map<String, dynamic>;
}
final Map<String, dynamic> stacktrace =
final stacktrace =
data.remove('stacktrace') as Map<String, dynamic>;

expect(stacktrace['frames'], const TypeMatcher<List>());
expect(stacktrace['frames'], isNotEmpty);

final Map<String, dynamic> topFrame =
final topFrame =
(stacktrace['frames'] as Iterable<dynamic>).last as Map<String, dynamic>;
expect(topFrame.keys, <String>[
'abs_path',
Expand Down