Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix merge conflict
  • Loading branch information
marandaneto committed Oct 20, 2020
commit ba721bdc735879ab69a9d29e2ff50e4df435f09d
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
- Added Scope and Breadcrumb ring buffer #109
- Added Hub to SDK #113
- Ref: Hub passes the Scope to SentryClient
- feat: sentry options #116

# `package:sentry` changelog

Expand Down
4 changes: 2 additions & 2 deletions dart/lib/src/noop_hub.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import 'dart:async';
import 'client.dart';
import 'hub.dart';
import 'protocol/event.dart';
import 'protocol/level.dart';
import 'protocol/sentry_level.dart';
import 'protocol/sentry_id.dart';

class NoOpHub implements Hub {
Expand All @@ -28,7 +28,7 @@ class NoOpHub implements Hub {
@override
Future<SentryId> captureMessage(
String message, {
SeverityLevel level = SeverityLevel.info,
SentryLevel level = SentryLevel.info,
String template,
List params,
}) =>
Expand Down
6 changes: 4 additions & 2 deletions dart/lib/src/sentry.dart
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,13 @@ class Sentry {
static void _init(SentryOptions options) {
if (isEnabled) {
options.logger(
SeverityLevel.warning,
SentryLevel.warning,
'Sentry has been already initialized. Previous configuration will be overwritten.',
);
}

_setDefaultConfiguration(options);

final hub = currentHub;
_hub = Hub(options);
hub.close();
Expand All @@ -57,7 +59,7 @@ class Sentry {

Future<SentryId> captureMessage(
String message, {
SeverityLevel level,
SentryLevel level,
String template,
List<dynamic> params,
}) async {
Expand Down
2 changes: 1 addition & 1 deletion dart/test/hub_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ void main() {
verify(
client.captureMessage(
fakeMessage.formatted,
level: SeverityLevel.info,
level: SentryLevel.info,
scope: anyNamed('scope'),
),
).called(1);
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.