unified fixes

CHANGELOG.md

@@ -45,6 +45,7 @@
 - Ref: rename the `throwable` argument name to `exception` in `captureEvents(...)`
 - Ref : remove dsn from Transport public Api
 - update the Dart sdk constraint
+- fix : throws on invalid dsn
 
 # `package:sentry` changelog
 

dart/example/main.dart

@@ -81,8 +81,6 @@ Future<void> main() async {
   } finally {
     await Sentry.close();
   }
-
-  /* TODO(rxlabz) Sentry CaptureMessage(message, level) */
 }
 
 Future<void> loadConfig() async {

dart/lib/src/protocol/dsn.dart

@@ -46,15 +46,11 @@ class Dsn {
     final uri = Uri.parse(dsn);
     final userInfo = uri.userInfo.split(':');
 
-    assert(() {
-      if (uri.pathSegments.isEmpty) {
-        throw ArgumentError(
-          'Project ID not found in the URI path of the DSN URI: $dsn',
-        );
-      }
-
-      return true;
-    }());
+    if (uri.pathSegments.isEmpty) {
+      throw ArgumentError(
+        'Project ID not found in the URI path of the DSN URI: $dsn',
+      );
+    }
 
     return Dsn(
       publicKey: userInfo[0],

dart/lib/src/sentry_client.dart

@@ -22,7 +22,13 @@ abstract class SentryClient {
   SentryClient.base(this._options, {String origin}) {
     _random = _options.sampleRate == null ? null : Random();
     if (_options.transport is NoOpTransport) {
-      _options.transport = HttpTransport(options: _options, origin: origin);
+      try {
+        _options.transport = HttpTransport(options: _options, origin: origin);
+      } on ArgumentError catch (error) {
+        _options.logger(SentryLevel.error, '${error.message}');
+      } catch (err) {
+        _options.logger(SentryLevel.error, 'An exception occurred.');
+      }
     }
   }
 

dart/lib/src/transport/http_transport.dart

@@ -28,7 +28,7 @@ class HttpTransport implements Transport {
         _dsn = Dsn.parse(options.dsn),
         _headers = _buildHeaders(sdkIdentifier: options.sdk.identifier) {
     _credentialBuilder = CredentialBuilder(
-      dsn: Dsn.parse(options.dsn),
+      dsn: _dsn,
       clientId: options.sdk.identifier,
       clock: options.clock,
     );