debug

dart/lib/src/sentry_client.dart

@@ -74,7 +74,10 @@ class SentryClient {
         );
       }
       if (event == null) {
-        _options.logger(SentryLevel.debug, 'Event was dropped by a processor');
+        _options.logger(
+          SentryLevel.debug,
+          'Event was dropped by BeforeSend callback',
+        );
         return _sentryId;
       }
     }

dart/lib/src/sentry_exception_factory.dart

@@ -8,6 +8,7 @@ import 'throwable_mechanism.dart';
 /// class to convert Dart Error and exception to SentryException
 class SentryExceptionFactory {
   SentryStackTraceFactory _stacktraceFactory;
+  SentryOptions _options;
 
   SentryExceptionFactory({
     SentryStackTraceFactory stacktraceFactory,
@@ -17,6 +18,7 @@ class SentryExceptionFactory {
       throw ArgumentError('SentryOptions is required.');
     }
 
+    _options = options;
     _stacktraceFactory = stacktraceFactory ?? SentryStackTraceFactory(options);
   }
 

dart/lib/src/sentry_stack_trace_factory.dart

@@ -8,22 +8,13 @@ import 'sentry_options.dart';
 
 /// converts [StackTrace] to [SentryStackFrames]
 class SentryStackTraceFactory {
-  /// A list of string prefixes of module names that do not belong to the app, but rather third-party
-  /// packages. Modules considered not to be part of the app will be hidden from stack traces by
-  /// default.
-  List<String> _inAppExcludes;
-
-  /// A list of string prefixes of module names that belong to the app. This option takes precedence
-  /// over inAppExcludes.
-  List<String> _inAppIncludes;
+  SentryOptions _options;
 
   SentryStackTraceFactory(SentryOptions options) {
     if (options == null) {
       throw ArgumentError('SentryOptions is required.');
     }
-
-    _inAppExcludes = options.inAppExcludes;
-    _inAppIncludes = options.inAppIncludes;
+    _options = options;
   }
 
   /// returns the [SentryStackFrame] list from a stackTrace ([StackTrace] or [String])
@@ -34,6 +25,20 @@ class SentryStackTraceFactory {
         ? Chain.forTrace(stackTrace)
         : Chain.parse(stackTrace as String);
 
+    // if strip symbols are enabled, thats what we see:
+    // warning:  This VM has been configured to produce stack traces that violate the Dart standard.
+    // ***       *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
+    // unparsed  pid: 30930, tid: 30990, name 1.ui
+    // unparsed  build_id: '5346e01103ffeed44e97094ff7bfcc19'
+    // unparsed  isolate_dso_base: 723d447000, vm_dso_base: 723d447000
+    // unparsed  isolate_instructions: 723d452000, vm_instructions: 723d449000
+    // unparsed      #00 abs 000000723d6346d7 virt 00000000001ed6d7 _kDartIsolateSnapshotInstructions+0x1e26d7
+    // unparsed      #01 abs 000000723d637527 virt 00000000001f0527 _kDartIsolateSnapshotInstructions+0x1e5527
+    // unparsed      #02 abs 000000723d4a41a7 virt 000000000005d1a7 _kDartIsolateSnapshotInstructions+0x521a7
+    // unparsed      #03 abs 000000723d624663 virt 00000000001dd663 _kDartIsolateSnapshotInstructions+0x1d2663
+    // unparsed      #04 abs 000000723d4b8c3b virt 0000000000071c3b _kDartIsolateSnapshotInstructions+0x66c3b
+    // unparsed      #05 abs 000000723d5ffe27 virt 00000000001b8e27 _kDartIsolateSna
+
     final frames = <SentryStackFrame>[];
     for (var t = 0; t < chain.traces.length; t += 1) {
       final encodedFrames =
@@ -52,16 +57,29 @@ class SentryStackTraceFactory {
   /// converts [Frame] to [SentryStackFrame]
   @visibleForTesting
   SentryStackFrame encodeStackTraceFrame(Frame frame) {
+    _options.logger(SentryLevel.debug,
+        'frame uri: ${frame.uri}'); // warning if split symbols
+    _options.logger(SentryLevel.debug,
+        'frame uri segs: ${frame.uri.pathSegments}'); // segs []
     final fileName =
         frame.uri.pathSegments.isNotEmpty ? frame.uri.pathSegments.last : null;
 
+    _options.logger(SentryLevel.debug, 'file name: ${fileName}');
+
+    final abs = '$eventOrigin${_absolutePathForCrashReport(frame)}';
+    _options.logger(SentryLevel.debug, 'abs: ${abs}');
+    _options.logger(SentryLevel.debug, 'member: ${frame.member}');
+    _options.logger(SentryLevel.debug, 'inapp: ${isInApp(frame)}');
+    _options.logger(SentryLevel.debug, 'package: ${frame.package}');
+
     var sentryStackFrame = SentryStackFrame(
-      absPath: '$eventOrigin${_absolutePathForCrashReport(frame)}',
+      absPath: abs,
       function: frame.member,
       // https://docs.sentry.io/development/sdk-dev/features/#in-app-frames
       inApp: isInApp(frame),
       fileName: fileName,
       package: frame.package,
+      platform: 'native', // TODO: only if necessary to symbolicate
     );
 
     if (frame.line != null && frame.line >= 0) {
@@ -84,7 +102,10 @@ class SentryStackTraceFactory {
   /// "dart:" and "package:" imports are always relative and are OK to send in
   /// full.
   String _absolutePathForCrashReport(Frame frame) {
-    if (frame.uri.scheme != 'dart' && frame.uri.scheme != 'package') {
+    _options.logger(SentryLevel.debug, 'scheme ${frame.uri.scheme}');
+    if (frame.uri.scheme != 'dart' &&
+        frame.uri.scheme != 'package' &&
+        frame.uri.pathSegments.isNotEmpty) {
       return frame.uri.pathSegments.last;
     }
 
@@ -99,15 +120,15 @@ class SentryStackTraceFactory {
       return true;
     }
 
-    if (_inAppIncludes != null) {
-      for (final include in _inAppIncludes) {
+    if (_options.inAppIncludes != null) {
+      for (final include in _options.inAppIncludes) {
         if (frame.package != null && frame.package.startsWith(include)) {
           return true;
         }
       }
     }
-    if (_inAppExcludes != null) {
-      for (final exclude in _inAppExcludes) {
+    if (_options.inAppExcludes != null) {
+      for (final exclude in _options.inAppExcludes) {
         if (frame.package != null && frame.package.startsWith(exclude)) {
           return false;
         }

dart/test/exception_factory_test.dart

@@ -11,13 +11,8 @@ void main() {
       try {
         throw StateError('a state error');
       } catch (err, stacktrace) {
-        final mechanism = Mechanism(
-          type: 'example',
-          description: 'a mechanism',
-        );
         sentryException = exceptionFactory.getSentryException(
           err,
-          mechanism: mechanism,
           stackTrace: stacktrace,
         );
       }
@@ -31,13 +26,8 @@ void main() {
       try {
         throw StateError('a state error');
       } catch (err) {
-        final mechanism = Mechanism(
-          type: 'example',
-          description: 'a mechanism',
-        );
         sentryException = exceptionFactory.getSentryException(
           err,
-          mechanism: mechanism,
           stackTrace: '''
 #0      baz (file:///pathto/test.dart:50:3)
 <asynchronous suspension>

flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt

@@ -12,6 +12,8 @@ import android.content.Context
 import io.sentry.SentryEvent
 import io.sentry.SentryLevel
 import io.sentry.SentryOptions
+//import io.sentry.protocol.DebugImage
+//import io.sentry.protocol.DebugMeta
 import io.sentry.protocol.SdkVersion
 import java.io.File
 import java.util.UUID
@@ -115,11 +117,21 @@ class SentryFlutterPlugin : FlutterPlugin, MethodCallHandler {
         options.isEnableNdk = false
       }
 
+//      var debugImage: DebugMeta? = null
+
       options.setBeforeSend { event, _ ->
         setEventOriginTag(event)
         addPackages(event, options.sdkVersion)
         removeThreadsIfNotAndroid(event)
 
+//        if (event.debugMeta != null &&
+//                debugImage == null &&
+//                event.debugMeta.images != null &&
+//                event.debugMeta.images.isNotEmpty()) {
+//          debugImage = event.debugMeta
+//        }
+//        addDebugImagesIfFlutterEvent(event, debugImage)
+
         event
       }
 
@@ -192,4 +204,13 @@ class SentryFlutterPlugin : FlutterPlugin, MethodCallHandler {
       }
     }
   }
+
+//  private fun addDebugImagesIfFlutterEvent(event: SentryEvent, meta: DebugMeta?) {
+//    if (isValidSdk(event.sdk)) {
+//      // cal sentry-native to load debug meta
+//      if (event.sdk.name == "sentry.dart.flutter" && meta != null && event.debugMeta == null) {
+//        event.debugMeta = meta
+//      }
+//    }
+//  }
 }

flutter/example/android/app/build.gradle

@@ -28,7 +28,7 @@ apply plugin: 'com.ydq.android.gradle.native-aar.import'
 
 // uncomment this to upload proguard mapping file and debug symbols to Sentry
 // and also set the token (sentry.properties) file
-apply plugin: 'io.sentry.android.gradle'
+//apply plugin: 'io.sentry.android.gradle'
 
 android {
     compileOptions {
@@ -73,8 +73,8 @@ android {
 
     buildTypes {
         release {
-            minifyEnabled true
-            proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
+//            minifyEnabled true
+//            proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
             signingConfig signingConfigs.debug
         }
     }
@@ -92,7 +92,7 @@ dependencies {
 }
 
 // uncomment this to upload debug symbols to Sentry
- sentry {
-     uploadNativeSymbols true
-     includeNativeSources true
- }
+// sentry {
+//     uploadNativeSymbols true
+//     includeNativeSources true
+// }

flutter/example/lib/main.dart

@@ -4,6 +4,7 @@ import 'package:flutter/foundation.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter/services.dart';
 import 'package:sentry_flutter/sentry_flutter.dart';
+import 'package:sentry/sentry.dart';
 import 'package:universal_platform/universal_platform.dart';
 
 const String _release =
@@ -72,6 +73,10 @@ class _MyAppState extends State<MyApp> {
           children: [
             Center(child: Text('Running on: $_platformVersion\n')),
             const Center(child: Text('Release: $_release\n')),
+            RaisedButton(
+              child: const Text('Dart: try catch'),
+              onPressed: () => tryCatch(),
+            ),
             RaisedButton(
               child: const Text('Dart: throw null'),
               // Warning : not captured if a debugger is attached
@@ -166,6 +171,14 @@ class AndroidExample extends StatelessWidget {
   }
 }
 
+Future<void> tryCatch() async {
+  try {
+    throw StateError('whats happening here');
+  } catch (error, stackTrace) {
+    await Sentry.captureException(error, stackTrace: stackTrace);
+  }
+}
+
 class CocoaExample extends StatelessWidget {
   const CocoaExample({Key key}) : super(key: key);
 

flutter/lib/FileSystemTransport.dart

@@ -17,9 +17,11 @@ class FileSystemTransport implements Transport {
       'event_id': event.eventId.toString(),
       'sdk': _options.sdk.toJson()
     };
+
     final eventMap = event.toJson();
 
     final eventString = _jsonEncoder.convert(eventMap);
+    _options.logger(SentryLevel.debug, 'event string: $eventString');
 
     final itemHeaderMap = {
       'content_type': 'application/json',
@@ -28,9 +30,15 @@ class FileSystemTransport implements Transport {
     };
 
     final headerString = _jsonEncoder.convert(headerMap);
+    _options.logger(SentryLevel.debug, 'header string: $headerString');
+
     final itemHeaderString = _jsonEncoder.convert(itemHeaderMap);
+    _options.logger(SentryLevel.debug, 'item header string: $itemHeaderString');
+
     final envelopeString = '$headerString\n$itemHeaderString\n$eventString';
 
+    _options.logger(SentryLevel.debug, 'envelope string: $envelopeString');
+
     final args = [envelopeString];
     try {
       await _channel.invokeMethod('captureEnvelope', args);

flutter/lib/sentry_flutter.dart

@@ -30,7 +30,8 @@ mixin SentryFlutter {
     // our plugin can call into the native code.
     WidgetsFlutterBinding.ensureInitialized();
 
-    options.debug = kDebugMode;
+    // options.debug = kDebugMode;
+    options.debug = true;
 
     // web still uses a http transport
     if (!kIsWeb) {