-
-
Notifications
You must be signed in to change notification settings - Fork 277
Feat: Flutter integrations for the Dart SDK #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-garcia
reviewed
Nov 3, 2020
Member
bruno-garcia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great!
Co-authored-by: Bruno Garcia <[email protected]>
…t into feat/flutter-native
marandaneto
commented
Nov 10, 2020
marandaneto
commented
Nov 10, 2020
marandaneto
commented
Nov 12, 2020
rxlabz
reviewed
Nov 12, 2020
# Conflicts: # dart/lib/src/sentry_client.dart # dart/lib/src/sentry_exception_factory.dart # dart/lib/src/sentry_options.dart # dart/lib/src/sentry_stack_trace_factory.dart # dart/test/exception_factory_test.dart # flutter/example/lib/main.dart
rxlabz
reviewed
Nov 13, 2020
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt
Outdated
Show resolved
Hide resolved
marandaneto
commented
Nov 13, 2020
| } | ||
|
|
||
| SentryAndroid.init(context) { options -> | ||
| // TODO: check if args exist before assigning the values |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rxlabz
reviewed
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Feat: Flutter integrations for the Dart SDK
💡 Motivation and Context
We'd like to Support Flutter Apps ootb.
💚 How did you test it?
📝 Checklist
🔮 Next steps