Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
Prev Previous commit
Next Next commit
melos #8: flutter (#3135)
* Add melos setup and check only set up Dart for now

* Update

* Update]

* Update]

* Update

* Update

* Update

* Fix CHANGELOG

* Update gitignore

* Fix symlink in CHANGELOG

* Add logging to melos

* Update

* Update

* Update

* Update

* Add dio to packages

* Update workflow

* Update

* Update

* Update

* Update

* Update

* Add hive to packages

* Update

* Add file to packages

* Add link to packages

* Update

* Update

* Update

* Update

* Fix test

* Fix test

* Fix test

* Fix test

* Fix test

* Add flutter to packages

* Update

* Update

* Update

* Update

* Update

* Update

* Update
  • Loading branch information
buenaflor authored Aug 6, 2025
commit 9b0fceeaf74fd1ffe976b3a9b52d903bcda73f56
14 changes: 7 additions & 7 deletions .github/file-filters.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
# This is used by the action https://github.com/dorny/paths-filter

high_risk_code: &high_risk_code
- "flutter/lib/src/span_frame_metrics_collector.dart"
- "flutter/lib/src/integrations/native_app_start_integration.dart"
- "flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt"
- "flutter/ios/Classes/SentryFlutterPluginApple.swift"
- "flutter/lib/src/screenshot/recorder.dart"
- "flutter/lib/src/screenshot/widget_filter.dart"
- "flutter/lib/src/native/java/android_replay_recorder.dart"
- "packages/flutter/lib/src/span_frame_metrics_collector.dart"
- "packages/flutter/lib/src/integrations/native_app_start_integration.dart"
- "packages/flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt"
- "packages/flutter/ios/Classes/SentryFlutterPluginApple.swift"
- "packages/flutter/lib/src/screenshot/recorder.dart"
- "packages/flutter/lib/src/screenshot/widget_filter.dart"
- "packages/flutter/lib/src/native/java/android_replay_recorder.dart"
2 changes: 1 addition & 1 deletion .github/workflows/analyze.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:

- run: flutter pub get
if: ${{ inputs.package == 'flutter' }}
working-directory: flutter/microbenchmarks
working-directory: packages/flutter/microbenchmarks

- run: dart format --set-exit-if-changed ./

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/firebase_remote_config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ on:
- '.github/actions/dart-test/**'
- '.github/actions/coverage/**'
- 'dart/**'
- 'flutter/**'
- 'packages/flutter/**'
- 'firebase_remote_config/**'

# https://docs.github.com/en/actions/using-jobs/using-concurrency#example-using-a-fallback-value
Expand Down
24 changes: 12 additions & 12 deletions .github/workflows/flutter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ on:
- '.github/actions/coverage/**'
- '!**/*.md'
- '!**/class-diagram.svg'
- 'dart/**'
- 'flutter/**'
- 'packages/dart/**'
- 'packages/flutter/**'
- 'metrics/flutter.properties'

jobs:
Expand Down Expand Up @@ -61,20 +61,20 @@ jobs:

- uses: ./.github/actions/flutter-test
with:
directory: flutter
directory: packages/flutter

- uses: ./.github/actions/coverage
if: matrix.target == 'linux' && matrix.sdk == 'stable'
with:
token: ${{ secrets.CODECOV_TOKEN }}
directory: flutter
directory: packages/flutter
coverage: sentry_flutter
min-coverage: 90

- name: Build example for ${{ matrix.target }}
# The example currently doesn't support compiling for WASM. Should be OK once we add package:web in v9.
if: matrix.target != 'wasm'
working-directory: flutter/example
working-directory: packages/flutter/example
shell: bash
run: |
flutter config --enable-windows-desktop
Expand Down Expand Up @@ -110,7 +110,7 @@ jobs:
defaults:
run:
shell: bash
working-directory: flutter/example
working-directory: packages/flutter/example
strategy:
fail-fast: false
matrix:
Expand All @@ -136,7 +136,7 @@ jobs:
analyze:
uses: ./.github/workflows/analyze.yml
with:
package: flutter
package: packages/flutter
sdk: flutter
panaThreshold: 87

Expand All @@ -145,7 +145,7 @@ jobs:
timeout-minutes: 20
defaults:
run:
working-directory: ./flutter
working-directory: packages/flutter
steps:
- uses: actions/checkout@v4
# https://github.com/CocoaPods/CocoaPods/issues/5275#issuecomment-315461879
Expand All @@ -156,7 +156,7 @@ jobs:
timeout-minutes: 20
defaults:
run:
working-directory: ./flutter
working-directory: packages/flutter
steps:
- uses: actions/checkout@v4
- uses: norio-nomura/action-swiftlint@9f4dcd7fd46b4e75d7935cf2f4df406d5cae3684 # [email protected]
Expand All @@ -168,7 +168,7 @@ jobs:
timeout-minutes: 20
defaults:
run:
working-directory: ./flutter
working-directory: packages/flutter
steps:
- uses: actions/checkout@v4

Expand All @@ -185,7 +185,7 @@ jobs:
timeout-minutes: 20
steps:
- uses: actions/checkout@v4
# To recreate baseline run: detekt -i flutter/android,flutter/example/android -b flutter/config/detekt-bl.xml -cb
# To recreate baseline run: detekt -i packages/flutter/android,packages/flutter/example/android -b packages/flutter/config/detekt-bl.xml -cb
- uses: natiginfo/action-detekt-all@45229fbbe47eaff1160b6c956d7ffe14dc23c206 # [email protected]
with:
args: -i flutter/android,flutter/example/android --baseline flutter/config/detekt-bl.xml --jvm-target 1.8 --build-upon-default-config --all-rules
args: -i packages/flutter/android,packages/flutter/example/android --baseline packages/flutter/config/detekt-bl.xml --jvm-target 1.8 --build-upon-default-config --all-rules
22 changes: 11 additions & 11 deletions .github/workflows/flutter_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ on:
- '!**/*.md'
- '!**/class-diagram.svg'
- '.github/workflows/flutter_test.yml'
- 'dart/**'
- 'flutter/**'
- 'packages/dart/**'
- 'packages/flutter/**'

env:
SENTRY_AUTH_TOKEN_E2E: ${{ secrets.SENTRY_AUTH_TOKEN_E2E }}
Expand All @@ -29,7 +29,7 @@ jobs:
timeout-minutes: 30
defaults:
run:
working-directory: ./flutter/example
working-directory: packages/flutter/example
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -61,13 +61,13 @@ jobs:
# TODO: fix emulator caching, in ubuntu-latest emulator won't boot: https://github.com/ReactiveCircus/android-emulator-runner/issues/278

- name: build apk
working-directory: ./flutter/example/android
working-directory: packages/flutter/example/android
run: flutter build apk --debug --target-platform=android-x64

- name: launch android emulator & run android native test
uses: reactivecircus/android-emulator-runner@1dcd0090116d15e7c562f8db72807de5e036a4ed #[email protected]
with:
working-directory: ./flutter/example/android
working-directory: packages/flutter/example/android
api-level: 31
profile: Nexus 6
arch: x86_64
Expand All @@ -80,7 +80,7 @@ jobs:
- name: launch android emulator & run android integration test
uses: reactivecircus/android-emulator-runner@1dcd0090116d15e7c562f8db72807de5e036a4ed #[email protected]
with:
working-directory: ./flutter/example
working-directory: packages/flutter/example
api-level: 31
profile: Nexus 6
arch: x86_64
Expand All @@ -93,7 +93,7 @@ jobs:
- name: launch android emulator & run android integration test in profile mode
uses: reactivecircus/android-emulator-runner@1dcd0090116d15e7c562f8db72807de5e036a4ed #[email protected]
with:
working-directory: ./flutter/example
working-directory: packages/flutter/example
api-level: 31
profile: Nexus 6
arch: x86_64
Expand All @@ -109,7 +109,7 @@ jobs:
timeout-minutes: 30
defaults:
run:
working-directory: ./flutter/example
working-directory: packages/flutter/example
strategy:
fail-fast: false
matrix:
Expand All @@ -127,7 +127,7 @@ jobs:
- run: flutter pub get

- run: pod install
working-directory: ./flutter/example/${{ matrix.target }}
working-directory: packages/flutter/example/${{ matrix.target }}

- name: prepare test device
id: device
Expand Down Expand Up @@ -156,7 +156,7 @@ jobs:
# We only have the native unit test package in the iOS xcodeproj at the moment.
# Should be OK because it will likely be removed after switching to FFI (see https://github.com/getsentry/sentry-dart/issues/1444).
if: ${{ matrix.target != 'macos' }}
working-directory: ./flutter/example/${{ matrix.target }}
working-directory: packages/flutter/example/${{ matrix.target }}
run: xcodebuild test -workspace Runner.xcworkspace -scheme Runner -configuration Debug -destination "platform=$DEVICE_PLATFORM" -allowProvisioningUpdates CODE_SIGNING_ALLOWED=NO
env:
DEVICE_PLATFORM: ${{ steps.device.outputs.platform }}
Expand All @@ -166,7 +166,7 @@ jobs:
timeout-minutes: 30
defaults:
run:
working-directory: ./flutter/example
working-directory: packages/flutter/example
strategy:
fail-fast: false
matrix:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/metrics.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:
paths:
- .github/workflows/metrics.yml
- dart/**
- flutter/**
- packages/flutter/**
- metrics/**
- "!**/*.md"
branches-ignore:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/min_version_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ on:
- "!**/class-diagram.svg"
- ".github/workflows/min_version_test.yml"
- "dart/**"
- "flutter/**"
- "packages/flutter/**"
- "min_version_test/**"

jobs:
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/testflight.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,17 @@ jobs:
bundler-cache: true

- name: flutter
working-directory: ./flutter/example
working-directory: ./packages/flutter/example
run: |
flutter pub get
flutter build ios --no-codesign --obfuscate --split-debug-info=.

- name: Install Fastlane
working-directory: ./flutter/example/ios
working-directory: ./packages/flutter/example/ios
run: bundle install

- name: Bump, Build & Upload App to TestFlight
working-directory: ./flutter/example/ios
working-directory: ./packages/flutter/example/ios
env:
APP_STORE_CONNECT_KEY_ID: ${{ secrets.APP_STORE_CONNECT_KEY_ID }}
APP_STORE_CONNECT_ISSUER_ID: ${{ secrets.APP_STORE_CONNECT_ISSUER_ID }}
Expand All @@ -51,7 +51,7 @@ jobs:
bundle exec fastlane upload_testflight

- name: Upload Symbols to Sentry
working-directory: ./flutter/example
working-directory: ./packages/flutter/example
env:
SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
run: flutter packages pub run sentry_dart_plugin
8 changes: 4 additions & 4 deletions .github/workflows/update-deps.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,15 @@ jobs:
android:
uses: getsentry/github-workflows/.github/workflows/updater.yml@v2
with:
path: flutter/scripts/update-android.sh
path: packages/flutter/scripts/update-android.sh
name: Android SDK
secrets:
api-token: ${{ secrets.CI_DEPLOY_KEY }}

cocoa:
uses: getsentry/github-workflows/.github/workflows/updater.yml@v2
with:
path: flutter/scripts/update-cocoa.sh
path: packages/flutter/scripts/update-cocoa.sh
name: Cocoa SDK
runs-on: macos-latest
secrets:
Expand All @@ -30,15 +30,15 @@ jobs:
js:
uses: getsentry/github-workflows/.github/workflows/updater.yml@v2
with:
path: flutter/scripts/update-js.sh
path: packages/flutter/scripts/update-js.sh
name: JavaScript SDK
secrets:
api-token: ${{ secrets.CI_DEPLOY_KEY }}

native:
uses: getsentry/github-workflows/.github/workflows/updater.yml@v2
with:
path: flutter/scripts/update-native.sh
path: packages/flutter/scripts/update-native.sh
name: Native SDK
secrets:
api-token: ${{ secrets.CI_DEPLOY_KEY }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/web-example-ghpages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,13 @@ jobs:
- uses: subosito/flutter-action@fd55f4c5af5b953cc57a2be44cb082c8f6635e8e # [email protected]
- uses: bluefireteam/flutter-gh-pages@cf4a9312849577dbfd9df8f3d63d12ef6b09898e # pin@v9
with:
workingDir: flutter/example
workingDir: packages/flutter/example
customArgs: --source-maps
webRenderer: canvaskit
baseHref: "/sentry-dart/"

- name: Upload source maps
run: |
cd flutter/example
cd packages/flutter/example
flutter pub get
dart run sentry_dart_plugin
1 change: 0 additions & 1 deletion flutter/CHANGELOG.md

This file was deleted.

1 change: 0 additions & 1 deletion flutter/dartdoc_options.yaml

This file was deleted.

This file was deleted.

3 changes: 0 additions & 3 deletions flutter/pubspec_overrides.yaml

This file was deleted.

3 changes: 3 additions & 0 deletions melos.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@ name: sentry_dart_workspace
packages:
- 'packages/**'

ignore:
- 'packages/flutter/example/' # ignore it for now

ide:
intellij:
moduleNamePrefix: ''
2 changes: 1 addition & 1 deletion metrics/prepare.sh
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ dependency_overrides:
sentry:
path: ../../packages/dart
sentry_flutter:
path: ../../flutter
path: ../../packages/flutter

EOF

Expand Down
6 changes: 3 additions & 3 deletions min_version_test/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,11 @@ dependency_overrides:
sentry:
path: ../packages/dart
sentry_flutter:
path: ../flutter
path: ../packages/flutter
sentry_dio:
path: ../dio
path: ../packages/dio
sentry_logging:
path: ../logging
path: ../packages/logging

# For information on the generic Dart part of this file, see the
# following page: https://dart.dev/tools/pub/pubspec
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
1 change: 1 addition & 0 deletions packages/flutter/CHANGELOG.md
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes
File renamed without changes.
1 change: 1 addition & 0 deletions packages/flutter/dartdoc_options.yaml
File renamed without changes.
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import 'dart:io';

import 'package:flutter_test/flutter_test.dart';
import 'package:sentry_flutter/sentry_flutter.dart';
import '../../../packages/dart/test/mocks/mock_transport.dart';
import '../../../dart/test/mocks/mock_transport.dart';

void main() {
final transport = MockTransport();
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
Loading
Loading