Skip to content

Conversation

@marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Mar 5, 2021

📜 Description

Feat: sentry and sentry_flutter null safety

#skip-changelog

💡 Motivation and Context

#247

💚 How did you test it?

running and unit tests

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@codecov-io
Copy link

codecov-io commented Mar 5, 2021

Codecov Report

Merging #335 (32d09c8) into main (4a7d680) will increase coverage by 2.96%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #335      +/-   ##
==========================================
+ Coverage   86.64%   89.60%   +2.96%     
==========================================
  Files          52       51       -1     
  Lines        1759     1636     -123     
==========================================
- Hits         1524     1466      -58     
+ Misses        235      170      -65     
Impacted Files Coverage Δ
dart/lib/src/hub_adapter.dart 16.66% <ø> (ø)
dart/lib/src/isolate_error_integration.dart 90.00% <ø> (ø)
dart/lib/src/noop_client.dart 14.81% <0.00%> (ø)
dart/lib/src/noop_hub.dart 33.33% <ø> (ø)
dart/lib/src/protocol/browser.dart 100.00% <ø> (ø)
dart/lib/src/protocol/gpu.dart 100.00% <ø> (ø)
dart/lib/src/protocol/operating_system.dart 97.36% <ø> (ø)
dart/lib/src/protocol/sdk_info.dart 100.00% <ø> (ø)
dart/lib/src/protocol/sentry_runtime.dart 100.00% <ø> (ø)
flutter/lib/src/sentry_flutter_options.dart 66.66% <16.66%> (+7.97%) ⬆️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a7d680...32d09c8. Read the comment docs.

@marandaneto marandaneto marked this pull request as ready for review March 8, 2021 07:20
@marandaneto marandaneto merged commit 83380c9 into main Mar 8, 2021
@marandaneto marandaneto deleted the feat/null-safety branch March 8, 2021 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants