Skip to content

Feat: sentry and sentry_flutter null safety #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marandaneto merged 8 commits into from
Mar 8, 2021
Merged

Feat: sentry and sentry_flutter null safety #335

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
423d367
Refactoring: Dart Nullsafety (#298)
ueman Feb 24, 2021
9550972
fix: merge main into feat/null-safety (#333)
marandaneto Mar 4, 2021
43e8ca3
fix merge
marandaneto Mar 5, 2021
b875e3b
rollback stable channels as null-safety is available thru the stable too
marandaneto Mar 5, 2021
e2077a1
fix changelog
marandaneto Mar 5, 2021
32d09c8
null safety on sentry_flutter (#337)
fzyzcjy Mar 7, 2021
2ab2935
reduce score, pana does not know null-safety yet
marandaneto Mar 8, 2021
87e6ff8
polish
marandaneto Mar 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@

# 4.0.6

* Fix: Do not append stack trace to the exception if there are no frames
* Fix: Empty DSN disables the SDK and runs the App

# 4.0.6

* Refactoring: Migrate Sentry Dart to null safety
* Fix: captureMessage defaults SentryLevel to info
* Fix: SentryEvent.throwable returns the unwrapped throwable instead of the throwableMechanism
Expand Down
2 changes: 0 additions & 2 deletions dart/lib/src/protocol/sentry_event.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,6 @@ class SentryEvent {

final dynamic _throwable;

final dynamic _throwable;

/// An object that was thrown.
///
/// It's `runtimeType` and `toString()` are logged.
Expand Down
1 change: 1 addition & 0 deletions dart/lib/src/sentry_exception_factory.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ class SentryExceptionFactory {
SentryStackTrace? sentryStackTrace;
if (stackTrace != null) {
final frames = _stacktraceFactory.getStackFrames(stackTrace);

if (frames.isNotEmpty) {
sentryStackTrace = SentryStackTrace(
frames: frames,
Expand Down
2 changes: 1 addition & 1 deletion dart/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ homepage: https://docs.sentry.io/platforms/dart/
repository: https://github.com/getsentry/sentry-dart

environment:
sdk: '>=2.12.0-259.9.beta <3.0.0'
sdk: '>=2.12.0 <3.0.0'

analyzer:
enable-experiment:
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.