Skip to content

Add port to support the server doesn't using 80 #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ZhihuiTian wants to merge 2 commits into from
Closed

Add port to support the server doesn't using 80 #39

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e59e24
Add port to support the server doesn't using 80.
Feb 27, 2019
002acf3
Fix unit test fails
Feb 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix unit test fails
  • Loading branch information
Zhihui Tian authored Feb 27, 2019
commit 002acf30d1d9b08684f81b65fe969cda71cb1f34
2 changes: 1 addition & 1 deletion lib/sentry.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ class SentryClient {

@visibleForTesting
String get postUri =>
'${dsnUri.scheme}://${dsnUri.host}:${dsnUri.port}/api/$projectId/store/';
'${dsnUri.scheme}://${dsnUri.host}${dsnUri.port != 80 && dsnUri.port != 443 ? ':' + dsnUri.port.toString() : ''}/api/$projectId/store/';
Copy link
Contributor

@yjbanov yjbanov Sep 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably a good time to switch from the => shorthand to a { } block syntax, and make port a variable.

Copy link
Contributor

@yjbanov yjbanov Sep 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

':' + dsnUri.port.toString() can be replaced with ':${dsnUri.port}'


/// Reports an [event] to Sentry.io.
Future<SentryResponse> capture(
Expand Down