Add port to support the server doesn't using 80 #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
approved? |
yjbanov
suggested changes
Sep 11, 2019
Contributor
yjbanov
left a comment
yjbanov
left a comment
There was a problem hiding this comment.
Thank you for the PR and sorry for the delay. This looks like a good feature.
Can you please add tests for this?
| @visibleForTesting | ||
| String get postUri => | ||
| '${dsnUri.scheme}://${dsnUri.host}/api/$projectId/store/'; | ||
| '${dsnUri.scheme}://${dsnUri.host}${dsnUri.port != 80 && dsnUri.port != 443 ? ':' + dsnUri.port.toString() : ''}/api/$projectId/store/'; |
Contributor
There was a problem hiding this comment.
This is probably a good time to switch from the => shorthand to a { } block syntax, and make port a variable.
| @visibleForTesting | ||
| String get postUri => | ||
| '${dsnUri.scheme}://${dsnUri.host}/api/$projectId/store/'; | ||
| '${dsnUri.scheme}://${dsnUri.host}${dsnUri.port != 80 && dsnUri.port != 443 ? ':' + dsnUri.port.toString() : ''}/api/$projectId/store/'; |
Contributor
There was a problem hiding this comment.
':' + dsnUri.port.toString() can be replaced with ':${dsnUri.port}'
|
Can this be pulled into master? My SDN: After a while I get: I tried again: without defining a port it says: |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.