Skip to content

support dsn that use non-regular port or contains prefix path #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yjbanov merged 3 commits into from
Oct 16, 2019
Merged

support dsn that use non-regular port or contains prefix path #42

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3484a90
fix getting `postUri` in SentryClient
yrom Sep 2, 2019
7e77952
apply dartfmt changes
yrom Sep 2, 2019
7ee48ca
Use explicit type of variables
yrom Oct 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
apply dartfmt changes
  • Loading branch information
@yrom
yrom committed Sep 2, 2019
commit 7e77952610f424a1a8ae807e4ff1114d7a5be0cd
2 changes: 1 addition & 1 deletion lib/sentry.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ class SentryClient {
var pathLength = dsnUri.pathSegments.length;
var apiPath;
if (pathLength > 1) {
// some paths would present before the projectID in the dsnUri
// some paths would present before the projectID in the dsnUri
apiPath =
(dsnUri.pathSegments.sublist(0, pathLength - 1) + ['api']).join('/');
} else {
Expand Down
6 changes: 4 additions & 2 deletions test/sentry_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,10 @@ import 'package:test/test.dart';

const String _testDsn = 'https://public:[email protected]/1';
const String _testDsnWithoutSecret = 'https://[email protected]/1';
const String _testDsnWithPath = 'https://public:[email protected]/path/1';
const String _testDsnWithPort = 'https://public:[email protected]:8888/1';
const String _testDsnWithPath =
'https://public:[email protected]/path/1';
const String _testDsnWithPort =
'https://public:[email protected]:8888/1';
void main() {
group('$SentryClient', () {
test('can parse DSN', () async {
Expand Down