Skip to content

support dsn that use non-regular port or contains prefix path #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yjbanov merged 3 commits into from
Oct 16, 2019
Merged

support dsn that use non-regular port or contains prefix path #42

yjbanov merged 3 commits into from
Oct 16, 2019

Conversation

@yrom
Copy link
Contributor

@yrom yrom commented Sep 2, 2019

This PR will modify the postUri value in SentryClient.

Added two test cases :

const String _testDsnWithPath = 'https://public:[email protected]/path/1';
const String _testDsnWithPort = 'https://public:[email protected]:8888/1';

yrom added 2 commits September 2, 2019 12:39
@yrom
fix getting postUri in SentryClient
3484a90 
1. dsn may specify non-regular port
2. dsn may contains some paths before the projectID
@yrom
apply dartfmt changes
7e77952
@yjbanov yjbanov self-requested a review September 25, 2019 17:11
yjbanov
yjbanov reviewed Oct 15, 2019
View reviewed changes
@yjbanov yjbanov mentioned this pull request Oct 15, 2019
Closed
yjbanov
yjbanov approved these changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! LGTM.

@yjbanov yjbanov merged commit 79ea153 into getsentry:master Oct 16, 2019
@yrom yrom deleted the fix-post-uri branch October 17, 2019 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@yjbanov yjbanov yjbanov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yrom @yjbanov