Fix beforeSend signature in code snippets for dart platforms #9770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A breaking change introduced in v8.0.0: getsentry/sentry-dart#1478
|
@romatallinn is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
@buenaflor can you please review? |
buenaflor
requested changes
Apr 23, 2024
Contributor
buenaflor
left a comment
buenaflor
left a comment
There was a problem hiding this comment.
Small correction on beforeBreadcrumb
Thanks for the pr!
platform-includes/configuration/before-breadcrumb-hint/dart.mdx
Outdated
Show resolved
Hide resolved
platform-includes/enriching-events/breadcrumbs/before-breadcrumb/dart.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Giancarlo Buenaflor <[email protected]>
Co-authored-by: Giancarlo Buenaflor <[email protected]>
Contributor
Author
|
@buenaflor good to go |
buenaflor
approved these changes
Apr 23, 2024
Contributor
|
@vivianyentran looks good from my side |
vivianyentran
approved these changes
Apr 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust documentation to reflect a breaking change to a
beforeSendsignature introduced in v8.0.0:hintnon-nullable inBeforeSendCallback,BeforeBreadcrumbCallandEventProcessorsentry-dart#1574BeforeSendCallbackhave non-nullable hint? sentry-dart#1478Pre-merge checklist
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.