Skip to content

Fix beforeSend signature in code snippets for dart platforms #9770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
buenaflor merged 3 commits into from
Apr 23, 2024
Merged

Fix beforeSend signature in code snippets for dart platforms #9770

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
50d8ac5
Fix beforeSend signature in code snippets for dart platforms
MrLightful Apr 22, 2024
c90e23d
Update beforeBreadcrumb signature for dart platforms (pt1)
MrLightful Apr 23, 2024
174aaa4
Update beforeBreadcrumb signature for dart platforms (pt2)
MrLightful Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix beforeSend signature in code snippets for dart platforms 
A breaking change introduced in v8.0.0: getsentry/sentry-dart#1478
  • Loading branch information
@MrLightful
MrLightful committed Apr 22, 2024
commit 50d8ac5bd884f549fc21237faf294d8b18ca8c9e
2 changes: 1 addition & 1 deletion platform-includes/configuration/before-breadcrumb-hint/dart.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
```dart
import 'package:sentry/sentry.dart';
Breadcrumb beforeBreadcrumb(Breadcrumb crumb, {Hint? hint}) {
Breadcrumb beforeBreadcrumb(Breadcrumb crumb, Hint hint) {
return hint is MyHint ? null : crumb;
}
Expand Down
2 changes: 1 addition & 1 deletion platform-includes/configuration/before-send-fingerprint/dart.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
```dart
import 'package:sentry/sentry.dart';

FutureOr<SentryEvent?> beforeSend(SentryEvent event, {Hint? hint}) async {
FutureOr<SentryEvent?> beforeSend(SentryEvent event, Hint hint) async {
if (event.throwable is DatabaseException) {
event = event.copyWith(fingerprint: ['database-connection-error']);
}
Expand Down
2 changes: 1 addition & 1 deletion platform-includes/configuration/before-send-hint/dart.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
```dart
import 'package:sentry/sentry.dart';

FutureOr<SentryEvent?> beforeSend(SentryEvent event, {Hint? hint}) async {
FutureOr<SentryEvent?> beforeSend(SentryEvent event, Hint hint) async {
return hint is MyHint ? null : event;
}

Expand Down
2 changes: 1 addition & 1 deletion platform-includes/configuration/before-send/dart.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
```dart
import 'package:sentry/sentry.dart';

FutureOr<SentryEvent?> beforeSend(SentryEvent event, {Hint? hint}) async {
FutureOr<SentryEvent?> beforeSend(SentryEvent event, Hint hint) async {
// Modify the event here:
event = event.copyWith(serverName: null); // Don't send server names.
return event;
Expand Down
2 changes: 1 addition & 1 deletion platform-includes/enriching-events/breadcrumbs/before-breadcrumb/dart.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
```dart
import 'package:sentry/sentry.dart';
Breadcrumb beforeBreadcrumb(Breadcrumb breadcrumb, {Hint? hint}) {
Breadcrumb beforeBreadcrumb(Breadcrumb breadcrumb, Hint hint) {
return 'a.spammy.Logger' == breadcrumb.category ? null : breadcrumb;
}
Expand Down
2 changes: 1 addition & 1 deletion platform-includes/set-fingerprint/basic/dart.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
```dart
import 'package:sentry/sentry.dart';

FutureOr<SentryEvent?> beforeSend(SentryEvent event, {Hint? hint}) async {
FutureOr<SentryEvent?> beforeSend(SentryEvent event, Hint hint) async {
if (event.throwable is DatabaseException) {
event = event.copyWith(fingerprint: ['database-connection-error']);
}
Expand Down
2 changes: 1 addition & 1 deletion platform-includes/set-fingerprint/database-connection/dart.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
```dart
import 'package:sentry/sentry.dart';

FutureOr<SentryEvent?> beforeSend(SentryEvent event, {Hint? hint}) async {
FutureOr<SentryEvent?> beforeSend(SentryEvent event, Hint hint) async {
if (event.throwable is DatabaseException) {
event = event.copyWith(fingerprint: ['database-connection-error']);
}
Expand Down
2 changes: 1 addition & 1 deletion platform-includes/set-fingerprint/rpc/dart.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ class MyRpcException implements Exception {
MyRpcException(this.function, this.httpStatusCode);
}

FutureOr<SentryEvent?> beforeSend(SentryEvent event, {Hint? hint}) async {
FutureOr<SentryEvent?> beforeSend(SentryEvent event, Hint hint) async {
if (event.throwable is MyRpcException) {
final exception = event.throwable as MyRpcException;
event = event.copyWith(fingerprint: [
Expand Down