Skip to content

Conversation

@bruno-garcia
Copy link
Member

@bruno-garcia bruno-garcia commented Aug 20, 2023

#skip-changelog

@getsentry getsentry deleted a comment from github-actions bot Aug 20, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 20, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 6a1df09

@bruno-garcia
Copy link
Member Author

@vaind got to build, but profiling tests are not running in CI 😅

@vaind
Copy link
Contributor

vaind commented Aug 20, 2023

@vaind got to build, but profiling tests are not running in CI 😅

GJ, anything I should look into or not just yet?

@bruno-garcia
Copy link
Member Author

@vaind got to build, but profiling tests are not running in CI 😅

GJ, anything I should look into or not just yet?

I'm looking into the whole sln/slnf stuff. I have a whole week to play with this too because of hackweek :) Thank you!

@bruno-garcia
Copy link
Member Author

self TODO:

try Environment.ProcessId instead of Process.GetCurrent

vaind added a commit that referenced this pull request Aug 21, 2023
commit 6a1df09
Author: Ivan Dlugos <[email protected]>
Date:   Mon Aug 21 14:19:53 2023 +0200

    timeout update

commit 833a319
Merge: eaa320b c1e4dad
Author: Ivan Dlugos <[email protected]>
Date:   Mon Aug 21 13:13:51 2023 +0200

    Merge branch 'main' into feat/profiling-low-overhead

commit eaa320b
Author: Bruno Garcia <[email protected]>
Date:   Sun Aug 20 20:30:09 2023 -0400

    debugging on sample

commit 1a593bc
Author: Bruno Garcia <[email protected]>
Date:   Sun Aug 20 20:10:34 2023 -0400

    fuck this slnf mess

commit b5cccee
Author: Bruno Garcia <[email protected]>
Date:   Sun Aug 20 17:53:03 2023 -0400

    add profile category

commit aa01035
Author: Bruno Garcia <[email protected]>
Date:   Sun Aug 20 16:35:52 2023 -0400

    pack profiling

commit 20286f4
Author: Bruno Garcia <[email protected]>
Date:   Sun Aug 20 16:35:18 2023 -0400

    new full sln file

commit 7c7404d
Author: Bruno Garcia <[email protected]>
Date:   Sun Aug 20 15:11:59 2023 -0400

    verify

commit f1ea1ec
Author: Bruno Garcia <[email protected]>
Date:   Sun Aug 20 14:34:44 2023 -0400

    fix tfm in script

commit 3a05994
Author: Bruno Garcia <[email protected]>
Date:   Sun Aug 20 14:16:24 2023 -0400

    fix benchmarks. Package it

commit bec4641
Author: Bruno Garcia <[email protected]>
Date:   Sun Aug 20 13:53:03 2023 -0400

    ignore obj

commit 791cdc6
Author: Bruno Garcia <[email protected]>
Date:   Sun Aug 20 13:52:01 2023 -0400

    fixed sln file with all but mobile

commit 915a0f2
Author: Bruno Garcia <[email protected]>
Date:   Sun Aug 20 13:29:28 2023 -0400

    sample

commit 67ef890
Author: Bruno Garcia <[email protected]>
Date:   Sun Aug 20 12:22:18 2023 -0400

    log on collection failure

commit 53715f4
Author: Bruno Garcia <[email protected]>
Date:   Sun Aug 20 11:46:30 2023 -0400

    set correct platform to profile

commit 43f78a0
Author: Bruno Garcia <[email protected]>
Date:   Sun Aug 20 11:20:07 2023 -0400

    gitignore on module

commit 40b6add
Author: Bruno Garcia <[email protected]>
Date:   Sun Aug 20 11:19:01 2023 -0400

    in SentryCore sln

commit 1c98746
Author: Bruno Garcia <[email protected]>
Date:   Sun Aug 20 11:14:02 2023 -0400

    builds!

commit 19e24a2
Author: Bruno Garcia <[email protected]>
Date:   Sun Aug 20 11:01:21 2023 -0400

    resolve errors

commit 6cb6cd1
Author: Bruno Garcia <[email protected]>
Date:   Sun Aug 20 10:20:55 2023 -0400

    fix structure

commit b346567
Author: Bruno Garcia <[email protected]>
Date:   Sun Aug 20 09:55:40 2023 -0400

    ignore build files from submodule perfview

commit 790d774
Author: Bruno Garcia <[email protected]>
Date:   Sun Aug 20 09:50:11 2023 -0400

    internal perfview

commit 6e2ae7c
Author: Bruno Garcia <[email protected]>
Date:   Sun Aug 20 09:41:09 2023 -0400

    remove profiling from sln/slnf

commit 3376bea
Author: Bruno Garcia <[email protected]>
Date:   Sun Aug 20 09:38:10 2023 -0400

    perfview under profiling

commit aee692b
Author: Bruno Garcia <[email protected]>
Date:   Sun Aug 20 08:54:41 2023 -0400

    perfview sampling

commit 0bbb0bd
Merge: 5ff8f1a b4f9485
Author: Bruno Garcia <[email protected]>
Date:   Sat Aug 19 18:56:53 2023 -0400

    Merge branch 'chore/integrate-traceevent' into feat/profiling-low-overhead

commit 5ff8f1a
Author: Bruno Garcia <[email protected]>
Date:   Sat Aug 19 18:54:43 2023 -0400

    profiling in core sln

commit b4f9485
Author: Ivan Dlugos <[email protected]>
Date:   Wed Aug 16 20:26:55 2023 +0200

    script & project updates

commit abc81db
Merge: 3a7a10f f457e3a
Author: Ivan Dlugos <[email protected]>
Date:   Wed Aug 16 19:23:29 2023 +0200

    Merge branch 'feat/streaming-tracelog' into chore/integrate-traceevent

commit 3a7a10f
Merge: 4ffb45a d915f98
Author: Stefan Jandl <[email protected]>
Date:   Wed Aug 16 16:28:53 2023 +0200

    Merge branch 'main' into chore/integrate-traceevent

commit 4ffb45a
Author: Bruno Garcia <[email protected]>
Date:   Mon Aug 14 15:08:31 2023 -0400

    submodule perfview sentry fork

commit 162ea2a
Author: Ivan Dlugos <[email protected]>
Date:   Sun Apr 23 23:04:20 2023 +0200

    prepare traceevent integration
@vaind
Copy link
Contributor

vaind commented Aug 21, 2023

I've squashed the relevant bits from this PR back into #2385 and we're adding the submodule without compiling it directly - using a project reference instead

@bruno-garcia
Copy link
Member Author

I've squashed the relevant bits from this PR back into #2385 and we're adding the submodule without compiling it directly - using a project reference instead

Cool! I'll close this

@bruno-garcia bruno-garcia deleted the feat/profiling-low-overhead branch August 22, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants