profiler - remove temp dir

benchmarks/Sentry.Benchmarks/ProfilingBenchmarks.cs

@@ -11,7 +11,7 @@ namespace Sentry.Benchmarks;
 public class ProfilingBenchmarks
 {
     private IHub _hub = Substitute.For<IHub>();
-    private ITransactionProfilerFactory _factory = new SamplingTransactionProfilerFactory(Path.GetTempPath(), new());
+    private ITransactionProfilerFactory _factory = new SamplingTransactionProfilerFactory(new());
 
     #region full transaction profiling
     public IEnumerable<object[]> ProfilerArguments()

src/Sentry.Profiling/SamplingTransactionProfiler.cs

@@ -15,14 +15,12 @@ internal class SamplingTransactionProfiler : ITransactionProfiler
     private readonly SentryStopwatch _stopwatch = SentryStopwatch.StartNew();
     private TimeSpan? _duration;
     private Task<MemoryStream>? _data;
-    private readonly string _tempDirectoryPath;
     private Transaction? _transaction;
     private readonly SentryOptions _options;
 
-    public SamplingTransactionProfiler(string tempDirectoryPath, SentryOptions options, CancellationToken cancellationToken)
+    public SamplingTransactionProfiler(SentryOptions options, CancellationToken cancellationToken)
     {
         _options = options;
-        _tempDirectoryPath = tempDirectoryPath;
         _cancellationToken = cancellationToken;
     }
 

src/Sentry.Profiling/SamplingTransactionProfilerFactory.cs

@@ -14,13 +14,10 @@ internal class SamplingTransactionProfilerFactory : ITransactionProfilerFactory
     // Stop profiling after the given number of milliseconds.
     private const int TIME_LIMIT_MS = 30_000;
 
-    private readonly string _tempDirectoryPath;
-
     private readonly SentryOptions _options;
 
-    public SamplingTransactionProfilerFactory(string tempDirectoryPath, SentryOptions options)
+    public SamplingTransactionProfilerFactory(SentryOptions options)
     {
-        _tempDirectoryPath = tempDirectoryPath;
         _options = options;
     }
 
@@ -33,7 +30,7 @@ public SamplingTransactionProfilerFactory(string tempDirectoryPath, SentryOption
             _options.LogDebug("Starting a sampling profiler session.");
             try
             {
-                var profiler = new SamplingTransactionProfiler(_tempDirectoryPath, _options, cancellationToken)
+                var profiler = new SamplingTransactionProfiler(_options, cancellationToken)
                 {
                     OnFinish = () => _inProgress = FALSE
                 };

src/Sentry.Profiling/SentryProfiling.cs

@@ -21,6 +21,6 @@ public ProfilingIntegration(string tempDirectoryPath)
     /// <inheritdoc/>
     public void Register(IHub hub, SentryOptions options)
     {
-        options.TransactionProfilerFactory = new SamplingTransactionProfilerFactory(_tempDirectoryPath, options);
+        options.TransactionProfilerFactory = new SamplingTransactionProfilerFactory(options);
     }
 }

test/Sentry.Profiling.Tests/SamplingTransactionProfilerTests.cs

@@ -62,7 +62,7 @@ public void Profiler_StartedNormally_Works()
         var hub = Substitute.For<IHub>();
         var transactionTracer = new TransactionTracer(hub, "test", "");
 
-        var factory = new SamplingTransactionProfilerFactory(Path.GetTempPath(), new SentryOptions { DiagnosticLogger = _testOutputLogger });
+        var factory = new SamplingTransactionProfilerFactory(new SentryOptions { DiagnosticLogger = _testOutputLogger });
         var clock = SentryStopwatch.StartNew();
         var sut = factory.Start(transactionTracer, CancellationToken.None);
         transactionTracer.TransactionProfiler = sut;
@@ -83,7 +83,7 @@ public void Profiler_AfterTimeout_Stops()
     {
         var hub = Substitute.For<IHub>();
         var options = new SentryOptions { DiagnosticLogger = _testOutputLogger };
-        var sut = new SamplingTransactionProfiler(Path.GetTempPath(), options, CancellationToken.None);
+        var sut = new SamplingTransactionProfiler(options, CancellationToken.None);
         var limitMs = 50;
         sut.Start(limitMs);
         RunForMs(limitMs * 4);