-
-
Notifications
You must be signed in to change notification settings - Fork 226
Bump .NET SDK to 9.0.300 #4259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump .NET SDK to 9.0.300 #4259
Changes from 5 commits
b2cb9ae
a75a064
7588936
91117b2
673baaf
093b9c9
557dc48
efdf50b
c97b467
613ebf2
2d07296
f306014
28ffb06
88516fb
40da347
fee498d
2d69608
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -67,7 +67,7 @@ runs: | |
| with: | ||
| dotnet-version: | | ||
| 8.0.x | ||
| 9.0.203 | ||
| 9.0.300 | ||
|
|
||
| - name: Install .NET Workloads | ||
| shell: bash | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| { | ||
| "sdk": { | ||
| "version": "9.0.203", | ||
| "workloadVersion": "9.0.203", | ||
| "version": "9.0.300", | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. questions
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
We frequently run into issues when new versions of .NET are released. They are, thus far, each unique... some easier than others to fix. This is why we pin the version of .NET and the workloads in the repo (it means we can still make PRs and do other work while we're trying to work out how to upgrade to the latest set of "surprises").
We definitely don't want to turn on roll forward (automatic updates) in the global.json file. Before we were pinning the workload/sdk version in global.json, I was spending 1-2 days per week, consistently, fluffing around with this stuff. Potentially we could try to automatically create a PR that bumps to the latest version of .NET, like we do with other dependencies. That would give us a way to upgrade regularly but without breaking the main branch and halting all other work. It could be a massive time sink though. It's hard to say whether we're better off making smaller bumps once every 6-8 weeks or having long periods of focus (where we're working on the SDK instead) and then taking all the pain in one hit occasionally (like now). I'm inclined to stick to what we're doing for the time being - there's just so much other stuff on the backlog without adding what seems to be very meta work around automating something like this. |
||
| "workloadVersion": "9.0.300", | ||
| "rollForward": "disable", | ||
| "allowPrerelease": false | ||
| } | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.