chore: Added IsNet8OrGreater build prop for readablility #4275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

jamescrosswell merged 10 commits into main from isnet8orgreater

Jun 18, 2025

Collaborator

jamescrosswell commented Jun 12, 2025

Resolves #4203:

Conditionally enabling Native support on net8.0 or later is confusing (or maybe broken) #4203

#skip-changelog

jamescrosswell added 5 commits

June 5, 2025 16:17


          chore: Added IsNet8OrGreater build prop for readablility

61fe9ac

Resolves #4203:
- #4203

#skip-changelog


          Merge branch 'main' into pr/4275

68ec285


          Update Sentry.Native.targets

e221b7f


          Update Directory.Build.props

31b6dcb


          Update Sentry.Native.targets

1965be3

Flash0ver reviewed

View reviewed changes

Directory.Build.props Outdated Show resolved Hide resolved

Flash0ver reviewed

View reviewed changes

src/Sentry/Platforms/Native/buildTransitive/Sentry.Native.targets Outdated Show resolved Hide resolved

Flash0ver reviewed

View reviewed changes

Directory.Build.props Outdated Show resolved Hide resolved

Flash0ver reviewed

View reviewed changes

Directory.Build.props Outdated Show resolved Hide resolved

Flash0ver reviewed

View reviewed changes

Directory.Build.props Outdated Show resolved Hide resolved

jamescrosswell added 3 commits

June 17, 2025 15:56


          Ensure common build props are available when building transitively

6d82a1d


          Update Directory.Build.props

a965edc


          Merge branch 'main' into isnet8orgreater

27635f5

jamescrosswell marked this pull request as ready for review

June 17, 2025 08:47

Flash0ver reviewed

View reviewed changes

src/Sentry/buildTransitive/Sentry.props Outdated Show resolved Hide resolved

jamescrosswell added 2 commits

June 18, 2025 15:06


          Renamed TargetFrameworkVersion to avoid conflicts


          Renamed IsNetXOrGreater build props to avoid potential conflicts

10a9aeb

jamescrosswell requested a review from Flash0ver

June 18, 2025 07:24

Flash0ver approved these changes

View reviewed changes

jamescrosswell merged commit b47c4db into main

29 checks passed

jamescrosswell deleted the isnet8orgreater branch

June 18, 2025 08:54

This was referenced Jun 19, 2025

Sentry 5.11 causes DllNotFoundException in Native AoT application #4296

Closed

fix: Native AOT linking #4298

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet