-
-
Notifications
You must be signed in to change notification settings - Fork 226
fix: Native AOT linking #4298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Native AOT linking #4298
Conversation
Without Directory.Build.props, nuget.config etc.
the integration test reads sentry version from there
|
Background: As you might notice from the commit history, I started with trying to make the existing integration test fail but eventually gave up. Since I had a set of commands (#4296 (comment)) I was able to use to reproduce the error locally, I decided to try running those in the CI. First, directly in the workflow for Linux, then as a manual test script for all platforms, and finally, I turned it into a Pester test script. The second last commit shows what kind of failures the new integration test produces when the properties are not correctly evaluated: ubuntu-22.04 (linux-x64)https://github.com/getsentry/sentry-dotnet/actions/runs/15779751203/job/44482314804 windows-latest (win-x64)https://github.com/getsentry/sentry-dotnet/actions/runs/15779751203/job/44482314808 |
This PR fixes a regression introduced by #4275: the
_SentryIsNet8OrGreaterhelper property was not correctly evaluated when publishing AOT, and Sentry was used as a NuGet package.The newly introduced integration test creates a minimal AOT app out of the tree in the system temp directory, and tests both
PublishAotand alsoPublishContaineron Linux with Docker available.Fixes: #4296