Skip to content

fix: Native AOT linking #4298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bruno-garcia merged 23 commits into from
Jun 21, 2025
Merged

fix: Native AOT linking #4298

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
19b741f
ci: use safer non-cone-mode sparse checkout for integration tests
jpnurmi Jun 19, 2025
2a82dff
top-level Directory.Build.props is required
jpnurmi Jun 19, 2025
5be8490
retain src/**/Release/*.(s)nupkg
jpnurmi Jun 19, 2025
9c8f845
dump preprocessed msbuild for integration test
jpnurmi Jun 19, 2025
2c84157
temp skip tests to speed up things
jpnurmi Jun 19, 2025
e900d6c
reorder
jpnurmi Jun 19, 2025
e1b1b72
diag Sentry.Native.targets
jpnurmi Jun 19, 2025
090070f
try binlog
jpnurmi Jun 19, 2025
5484bc8
fix binlog path
jpnurmi Jun 19, 2025
65ce81c
undo everything
jpnurmi Jun 19, 2025
199cb8c
ci: native-aot-docker
jpnurmi Jun 19, 2025
6474302
dotnet 9.0 & name
jpnurmi Jun 19, 2025
0903986
composite
jpnurmi Jun 19, 2025
1ec3d8c
test AOT on all platforms
jpnurmi Jun 19, 2025
49a3f8c
check if docker is available
jpnurmi Jun 20, 2025
51e9778
grouped and detailed output
jpnurmi Jun 20, 2025
28d776a
clean up docker containers
jpnurmi Jun 20, 2025
a6489dd
allow scripts for mac
jpnurmi Jun 20, 2025
1086327
try turning it into a pester integration test
jpnurmi Jun 20, 2025
44d819a
fix nuget.config
jpnurmi Jun 20, 2025
8a8315b
set NUGET_PACKAGES
jpnurmi Jun 20, 2025
81b051f
finally, apply the copy-paste fix
jpnurmi Jun 20, 2025
be9d67e
fix /var vs. /private/var mismatch on macos
jpnurmi Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
finally, apply the copy-paste fix
  • Loading branch information
@jpnurmi
jpnurmi committed Jun 20, 2025
commit 81b051f96a6d3a27c63bcc9bf92b71e387ba1713
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## Unreleased

### Fixes

- Fix linking of libsentry-native to avoid DllNotFoundException in Native AOT applications ([#4298](https://github.com/getsentry/sentry-dotnet/pull/4298))

## 5.11.0

### Features
Expand Down
7 changes: 7 additions & 0 deletions src/Sentry/Platforms/Native/buildTransitive/Sentry.Native.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,13 @@
Trim="true" />
</ItemGroup>

<!-- Helpful properties copied from Sentry.props -->
<PropertyGroup Condition="'$(TargetFramework)' != ''">
<_SentryTargetFrameworkVersion>$([MSBuild]::GetTargetFrameworkVersion($(TargetFramework)))</_SentryTargetFrameworkVersion>
<_SentryIsNet8OrGreater>$([MSBuild]::VersionGreaterThanOrEquals($(_SentryTargetFrameworkVersion), 8.0))</_SentryIsNet8OrGreater>
<_SentryIsNet9OrGreater>$([MSBuild]::VersionGreaterThanOrEquals($(_SentryTargetFrameworkVersion), 9.0))</_SentryIsNet9OrGreater>
</PropertyGroup>

<PropertyGroup>
<!-- net8.0 or greater -->
<FrameworkSupportsNative Condition="'$(_SentryIsNet8OrGreater)' == 'true' and ('$(OutputType)' == 'Exe' or '$(OutputType)' == 'WinExe')">true</FrameworkSupportsNative>
Expand Down
Loading