Skip to content

fix(logs): race condition in high volume logging scenarios #4428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Flash0ver merged 16 commits into from
Aug 15, 2025
Merged

fix(logs): race condition in high volume logging scenarios #4428

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
a4d2607
perf: remove NSubstitute from benchmark for Structured Logs
Flash0ver Aug 10, 2025
17bbed7
fix(logs): race condition when flushing Batch-Buffer
Flash0ver Aug 10, 2025
089fffc
ref(logs): pass arguments explicitly to Wait method
Flash0ver Aug 10, 2025
34c992f
docs(logs): more precise comments
Flash0ver Aug 10, 2025
3608899
ref(logs): more Debug.Assert
Flash0ver Aug 10, 2025
0c75df7
ref(logs): no longer enter Counter-Scopes when a Lock-Scope has been …
Flash0ver Aug 11, 2025
0b7c248
perf: add Parallel benchmark for Structured Logs
Flash0ver Aug 11, 2025
43d9772
Merge branch 'main' into fix/logs-event-lock-scope-race-condition
Flash0ver Aug 11, 2025
19ba13a
perf(logs): restore previous performance characteristics
Flash0ver Aug 11, 2025
f6265b0
docs: CHANGELOG
Flash0ver Aug 11, 2025
98b0379
perf(logs): update Benchmark result
Flash0ver Aug 14, 2025
186fe1e
Merge branch 'main' into fix/logs-event-lock-scope-race-condition
Flash0ver Aug 14, 2025
2608bf4
merge(logs): CHANGELOG
Flash0ver Aug 14, 2025
21b4f71
docs(logs): rephrase CHANGELOG
Flash0ver Aug 14, 2025
9e10df7
Merge branch 'main' into fix/logs-event-lock-scope-race-condition
jamescrosswell Aug 15, 2025
b1d5441
docs: rephrase CHANGELOG
Flash0ver Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
perf: add Parallel benchmark for Structured Logs
  • Loading branch information
@Flash0ver
Flash0ver committed Aug 11, 2025
commit 0b7c2486fcea1a0e397960a53e65e610dde6f658
22 changes: 14 additions & 8 deletions ...esults/Sentry.Benchmarks.StructuredLogBatchProcessorBenchmarks-report-github.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,17 @@ Apple M3 Pro, 1 CPU, 12 logical and 12 physical cores


```
| Method | BatchCount | OperationsPerInvoke | Mean | Error | StdDev | Gen0 | Allocated |
|---------------- |----------- |-------------------- |------------:|---------:|---------:|-------:|----------:|
| **EnqueueAndFlush** | **10** | **100** | **1,774.5 ns** | **7.57 ns** | **6.71 ns** | **0.6104** | **5 KB** |
| **EnqueueAndFlush** | **10** | **200** | **3,468.5 ns** | **11.16 ns** | **10.44 ns** | **1.2207** | **10 KB** |
| **EnqueueAndFlush** | **10** | **1000** | **17,259.7 ns** | **51.92 ns** | **46.02 ns** | **6.1035** | **50 KB** |
| **EnqueueAndFlush** | **100** | **100** | **857.5 ns** | **4.21 ns** | **3.73 ns** | **0.1469** | **1.2 KB** |
| **EnqueueAndFlush** | **100** | **200** | **1,681.4 ns** | **1.74 ns** | **1.63 ns** | **0.2937** | **2.41 KB** |
| **EnqueueAndFlush** | **100** | **1000** | **8,302.2 ns** | **12.00 ns** | **10.64 ns** | **1.4648** | **12.03 KB** |
| Method | BatchCount | OperationsPerInvoke | Mean | Error | StdDev | Median | Gen0 | Allocated |
|------------------------- |----------- |-------------------- |-----------:|----------:|----------:|-----------:|-------:|----------:|
| **EnqueueAndFlush** | **10** | **100** | **3.087 μs** | **0.0305 μs** | **0.0286 μs** | **3.077 μs** | **0.6104** | **5 KB** |
| EnqueueAndFlush_Parallel | 10 | 100 | 22.359 μs | 0.1047 μs | 0.0979 μs | 22.370 μs | 1.2207 | 9.98 KB |
| **EnqueueAndFlush** | **10** | **200** | **6.192 μs** | **0.0263 μs** | **0.0246 μs** | **6.188 μs** | **1.2207** | **10 KB** |
| EnqueueAndFlush_Parallel | 10 | 200 | 50.020 μs | 0.0814 μs | 0.0761 μs | 50.011 μs | 1.7090 | 13.92 KB |
| **EnqueueAndFlush** | **10** | **1000** | **29.180 μs** | **0.5809 μs** | **0.9044 μs** | **28.735 μs** | **6.1035** | **50 KB** |
| EnqueueAndFlush_Parallel | 10 | 1000 | 245.169 μs | 4.1653 μs | 3.8962 μs | 246.642 μs | 4.8828 | 43.35 KB |
| **EnqueueAndFlush** | **100** | **100** | **2.235 μs** | **0.0441 μs** | **0.1014 μs** | **2.262 μs** | **0.1450** | **1.2 KB** |
| EnqueueAndFlush_Parallel | 100 | 100 | 22.153 μs | 0.4426 μs | 0.9141 μs | 22.353 μs | 0.7019 | 5.86 KB |
| **EnqueueAndFlush** | **100** | **200** | **4.712 μs** | **0.0878 μs** | **0.0821 μs** | **4.678 μs** | **0.2899** | **2.41 KB** |
| EnqueueAndFlush_Parallel | 100 | 200 | 52.853 μs | 1.0549 μs | 2.2020 μs | 53.331 μs | 0.9155 | 7.52 KB |
| **EnqueueAndFlush** | **100** | **1000** | **22.633 μs** | **0.4470 μs** | **0.4390 μs** | **22.302 μs** | **1.4648** | **12.03 KB** |
| EnqueueAndFlush_Parallel | 100 | 1000 | 337.335 μs | 3.8933 μs | 3.6418 μs | 337.324 μs | 2.4414 | 20.71 KB |
10 changes: 10 additions & 0 deletions benchmarks/Sentry.Benchmarks/StructuredLogBatchProcessorBenchmarks.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,16 @@ public void EnqueueAndFlush()
_batchProcessor.Flush();
}

[Benchmark]
public void EnqueueAndFlush_Parallel()
{
_ = Parallel.For(0, OperationsPerInvoke, (int i) =>
{
_batchProcessor.Enqueue(_log);
});
_batchProcessor.Flush();
}

[GlobalCleanup]
public void Cleanup()
{
Expand Down