Skip to content

fix(logs): race condition in high volume logging scenarios #4428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Flash0ver merged 16 commits into from
Aug 15, 2025
Merged

fix(logs): race condition in high volume logging scenarios #4428

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
a4d2607
perf: remove NSubstitute from benchmark for Structured Logs
Flash0ver Aug 10, 2025
17bbed7
fix(logs): race condition when flushing Batch-Buffer
Flash0ver Aug 10, 2025
089fffc
ref(logs): pass arguments explicitly to Wait method
Flash0ver Aug 10, 2025
34c992f
docs(logs): more precise comments
Flash0ver Aug 10, 2025
3608899
ref(logs): more Debug.Assert
Flash0ver Aug 10, 2025
0c75df7
ref(logs): no longer enter Counter-Scopes when a Lock-Scope has been …
Flash0ver Aug 11, 2025
0b7c248
perf: add Parallel benchmark for Structured Logs
Flash0ver Aug 11, 2025
43d9772
Merge branch 'main' into fix/logs-event-lock-scope-race-condition
Flash0ver Aug 11, 2025
19ba13a
perf(logs): restore previous performance characteristics
Flash0ver Aug 11, 2025
f6265b0
docs: CHANGELOG
Flash0ver Aug 11, 2025
98b0379
perf(logs): update Benchmark result
Flash0ver Aug 14, 2025
186fe1e
Merge branch 'main' into fix/logs-event-lock-scope-race-condition
Flash0ver Aug 14, 2025
2608bf4
merge(logs): CHANGELOG
Flash0ver Aug 14, 2025
21b4f71
docs(logs): rephrase CHANGELOG
Flash0ver Aug 14, 2025
9e10df7
Merge branch 'main' into fix/logs-event-lock-scope-race-condition
jamescrosswell Aug 15, 2025
b1d5441
docs: rephrase CHANGELOG
Flash0ver Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(logs): race condition when flushing Batch-Buffer
  • Loading branch information
@Flash0ver
Flash0ver committed Aug 10, 2025
commit 17bbed7ed2be144ad00271fc1fa3daaccdc8efed
9 changes: 4 additions & 5 deletions src/Sentry/Threading/ScopedCountdownLock.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,13 +84,12 @@ internal LockScope TryEnterLockScope()

private void ExitLockScope()
{
if (Interlocked.CompareExchange(ref _isEngaged, 0, 1) == 1)
_event.Reset(); // reset the signaled event to the initial count of 1, so that new `CounterScope`s can be entered again

if (Interlocked.CompareExchange(ref _isEngaged, 0, 1) != 1)
{
_event.Reset(); // reset the signaled event to the initial count of 1, so that new `CounterScope`s can be entered again
return;
Debug.Fail("The Lock should have not been disengaged without being engaged first.");
}

Debug.Fail("The Lock should have not been disengaged without being engaged first.");
}

/// <inheritdoc />
Expand Down