Skip to content

Improve SentryHttpFailedRequestHandler issue grouping #4724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamescrosswell merged 21 commits into from
Nov 19, 2025
Merged

Improve SentryHttpFailedRequestHandler issue grouping #4724

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
19c0b76
Add new HttpStatusCodeRangeExtensions and tests.
ericsampson Nov 11, 2025
8b3ea27
Improve tests.
ericsampson Nov 11, 2025
56e3bf8
Add test that currently fails to prove the fix works.
ericsampson Nov 11, 2025
b97a6bd
Enhance the HttpFailedRequestHandler so that it captures a full excep…
ericsampson Nov 11, 2025
fd65e67
Merge branch 'main' into SentryHttpMessageHandler-issue-grouping
ericsampson Nov 17, 2025
02e69b1
Delete tests for deleted functionality.
ericsampson Nov 17, 2025
c9da3c7
Update test/Sentry.Tests/HttpStatusCodeRangeExtensionsTests.cs
ericsampson Nov 17, 2025
a07ed5d
Switch to using ExceptionDispatchInfo.SetCurrentStackTrace
ericsampson Nov 17, 2025
c4b981d
Update re PR feedback
ericsampson Nov 17, 2025
ced8585
Update with PR feedback
ericsampson Nov 17, 2025
7a1573a
PR feedback
ericsampson Nov 17, 2025
02a16b4
PR feedback
ericsampson Nov 17, 2025
77132f5
Add note to changelog
ericsampson Nov 17, 2025
46bcc41
Update src/Sentry/SentryHttpFailedRequestHandler.cs
ericsampson Nov 17, 2025
70232c3
Update src/Sentry/SentryHttpFailedRequestHandler.cs re method availab…
ericsampson Nov 18, 2025
7a90dac
format test/Sentry.Tests/SentryHttpFailedRequestHandlerTests.cs
ericsampson Nov 18, 2025
f8edf37
Update test for running on .NET5+
ericsampson Nov 18, 2025
e3fc2bc
Merge branch 'main' into SentryHttpMessageHandler-issue-grouping
ericsampson Nov 18, 2025
c76afd1
update Changelog re PR feedback
ericsampson Nov 18, 2025
885d728
Update CHANGELOG.md
ericsampson Nov 19, 2025
3901dd0
Merge branch 'main' into SentryHttpMessageHandler-issue-grouping
ericsampson Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
PR feedback
  • Loading branch information
@ericsampson
ericsampson committed Nov 17, 2025
commit 7a1573aaa5616c875bd572533d07bef7bd2834e3
22 changes: 11 additions & 11 deletions test/Sentry.Tests/HttpStatusCodeRangeExtensionsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ namespace Sentry.Tests;
public class HttpStatusCodeRangeExtensionsTests
{
[Fact]
public void Contains_EmptyList_ReturnsFalse()
public void ContainsStatusCode_EmptyList_ReturnsFalse()
{
// Arrange
var ranges = new List<HttpStatusCodeRange>();
Expand All @@ -19,7 +19,7 @@ public void Contains_EmptyList_ReturnsFalse()
[InlineData(400)]
[InlineData(450)]
[InlineData(499)]
public void Contains_SingleRangeInRange_ReturnsTrue(int statusCode)
public void ContainsStatusCode_SingleRangeInRange_ReturnsTrue(int statusCode)
{
// Arrange
var ranges = new List<HttpStatusCodeRange> { (400, 499) };
Expand All @@ -35,7 +35,7 @@ public void Contains_SingleRangeInRange_ReturnsTrue(int statusCode)
[InlineData(200)]
[InlineData(399)]
[InlineData(500)]
public void Contains_SingleRangeOutOfRange_ReturnsFalse(int statusCode)
public void ContainsStatusCode_SingleRangeOutOfRange_ReturnsFalse(int statusCode)
{
// Arrange
var ranges = new List<HttpStatusCodeRange> { (400, 499) };
Expand All @@ -52,7 +52,7 @@ public void Contains_SingleRangeOutOfRange_ReturnsFalse(int statusCode)
[InlineData(404)] // In first range
[InlineData(500)] // In second range
[InlineData(503)] // In second range
public void Contains_MultipleRangesInAnyRange_ReturnsTrue(int statusCode)
public void ContainsStatusCode_MultipleRangesInAnyRange_ReturnsTrue(int statusCode)
{
// Arrange
var ranges = new List<HttpStatusCodeRange> { (400, 404), (500, 503) };
Expand All @@ -69,7 +69,7 @@ public void Contains_MultipleRangesInAnyRange_ReturnsTrue(int statusCode)
[InlineData(405)] // Between ranges
[InlineData(499)] // Between ranges
[InlineData(504)] // Above ranges
public void Contains_MultipleRangesNotInAnyRange_ReturnsFalse(int statusCode)
public void ContainsStatusCode_MultipleRangesNotInAnyRange_ReturnsFalse(int statusCode)
{
// Arrange
var ranges = new List<HttpStatusCodeRange> { (400, 404), (500, 503) };
Expand All @@ -86,7 +86,7 @@ public void Contains_MultipleRangesNotInAnyRange_ReturnsFalse(int statusCode)
[InlineData(425)] // In overlap
[InlineData(450)] // In overlap
[InlineData(475)] // In second range only
public void Contains_OverlappingRangesInUnion_ReturnsTrue(int statusCode)
public void ContainsStatusCode_OverlappingRangesInUnion_ReturnsTrue(int statusCode)
{
// Arrange
var ranges = new List<HttpStatusCodeRange> { (400, 450), (425, 475) };
Expand All @@ -103,7 +103,7 @@ public void Contains_OverlappingRangesInUnion_ReturnsTrue(int statusCode)
[InlineData(399)] // Below first range
[InlineData(476)] // Above second range
[InlineData(500)] // Above second range
public void Contains_OverlappingRangesOutsideUnion_ReturnsFalse(int statusCode)
public void ContainsStatusCode_OverlappingRangesOutsideUnion_ReturnsFalse(int statusCode)
{
// Arrange
var ranges = new List<HttpStatusCodeRange> { (400, 450), (425, 475) };
Expand All @@ -116,7 +116,7 @@ public void Contains_OverlappingRangesOutsideUnion_ReturnsFalse(int statusCode)
}

[Fact]
public void Contains_SingleValueRangeExactMatch_ReturnsTrue()
public void ContainsStatusCode_SingleValueRangeExactMatch_ReturnsTrue()
{
// Arrange
var ranges = new List<HttpStatusCodeRange> { 404 };
Expand All @@ -131,7 +131,7 @@ public void Contains_SingleValueRangeExactMatch_ReturnsTrue()
[Theory]
[InlineData(403)]
[InlineData(405)]
public void Contains_SingleValueRangeNoMatch_ReturnsFalse(int statusCode)
public void ContainsStatusCode_SingleValueRangeNoMatch_ReturnsFalse(int statusCode)
{
// Arrange
var ranges = new List<HttpStatusCodeRange> { 404 };
Expand All @@ -144,7 +144,7 @@ public void Contains_SingleValueRangeNoMatch_ReturnsFalse(int statusCode)
}

[Fact]
public void Contains_HttpStatusCodeEnumInRange_ReturnsTrue()
public void ContainsStatusCode_HttpStatusCodeEnumInRange_ReturnsTrue()
{
// Arrange
var ranges = new List<HttpStatusCodeRange> { (400, 499) };
Expand All @@ -157,7 +157,7 @@ public void Contains_HttpStatusCodeEnumInRange_ReturnsTrue()
}

[Fact]
public void Contains_HttpStatusCodeEnumOutOfRange_ReturnsFalse()
public void ContainsStatusCode_HttpStatusCodeEnumOutOfRange_ReturnsFalse()
{
// Arrange
var ranges = new List<HttpStatusCodeRange> { (400, 499) };
Expand Down