Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
19c0b76
Add new HttpStatusCodeRangeExtensions and tests.
ericsampson Nov 11, 2025
8b3ea27
Improve tests.
ericsampson Nov 11, 2025
56e3bf8
Add test that currently fails to prove the fix works.
ericsampson Nov 11, 2025
b97a6bd
Enhance the HttpFailedRequestHandler so that it captures a full excep…
ericsampson Nov 11, 2025
fd65e67
Merge branch 'main' into SentryHttpMessageHandler-issue-grouping
ericsampson Nov 17, 2025
02e69b1
Delete tests for deleted functionality.
ericsampson Nov 17, 2025
c9da3c7
Update test/Sentry.Tests/HttpStatusCodeRangeExtensionsTests.cs
ericsampson Nov 17, 2025
a07ed5d
Switch to using ExceptionDispatchInfo.SetCurrentStackTrace
ericsampson Nov 17, 2025
c4b981d
Update re PR feedback
ericsampson Nov 17, 2025
ced8585
Update with PR feedback
ericsampson Nov 17, 2025
7a1573a
PR feedback
ericsampson Nov 17, 2025
02a16b4
PR feedback
ericsampson Nov 17, 2025
77132f5
Add note to changelog
ericsampson Nov 17, 2025
46bcc41
Update src/Sentry/SentryHttpFailedRequestHandler.cs
ericsampson Nov 17, 2025
70232c3
Update src/Sentry/SentryHttpFailedRequestHandler.cs re method availab…
ericsampson Nov 18, 2025
7a90dac
format test/Sentry.Tests/SentryHttpFailedRequestHandlerTests.cs
ericsampson Nov 18, 2025
f8edf37
Update test for running on .NET5+
ericsampson Nov 18, 2025
e3fc2bc
Merge branch 'main' into SentryHttpMessageHandler-issue-grouping
ericsampson Nov 18, 2025
c76afd1
update Changelog re PR feedback
ericsampson Nov 18, 2025
885d728
Update CHANGELOG.md
ericsampson Nov 19, 2025
3901dd0
Merge branch 'main' into SentryHttpMessageHandler-issue-grouping
ericsampson Nov 19, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update re PR feedback
  • Loading branch information
ericsampson committed Nov 17, 2025
commit c4b981d5d676d69aa9c1688a4e89181a1e6b24d0
17 changes: 8 additions & 9 deletions test/Sentry.Tests/SentryHttpFailedRequestHandlerTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -54,14 +54,13 @@ public void HandleResponse_Disabled_DontCapture()
[InlineData(403)] // Forbidden
[InlineData(404)] // Not Found
[InlineData(499)] // Edge of client error range
[InlineData(600)] // Beyond standard range
[InlineData(600)] // Beyond default range
public void HandleResponse_EnabledButNotInRange_DontCapture(int statusCode)
{
// Arrange
var sut = GetSut(new SentryOptions
{
CaptureFailedRequests = true
// default FailedRequestStatusCodes = (500,599)
});

var response = new HttpResponseMessage((HttpStatusCode)statusCode);
Expand All @@ -79,7 +78,7 @@ public void HandleResponse_EnabledButNotInRange_DontCapture(int statusCode)
[InlineData(401)] // Unauthorized - in range
[InlineData(404)] // Not Found - in range
[InlineData(499)] // Edge of range
public void HandleResponse_CustomRange_InRange_DoCapture(int statusCode)
public void HandleResponse_CustomRangeInRange_DoCapture(int statusCode)
{
// Arrange
var options = new SentryOptions
Expand All @@ -104,7 +103,7 @@ public void HandleResponse_CustomRange_InRange_DoCapture(int statusCode)
[InlineData(399)] // Edge below range
[InlineData(500)] // Internal Server Error - above range
[InlineData(503)] // Service Unavailable - above range
public void HandleResponse_CustomRange_OutOfRange_DontCapture(int statusCode)
public void HandleResponse_CustomRangeOutOfRange_DontCapture(int statusCode)
{
// Arrange
var options = new SentryOptions
Expand All @@ -129,7 +128,7 @@ public void HandleResponse_CustomRange_OutOfRange_DontCapture(int statusCode)
[InlineData(201)] // Created
[InlineData(204)] // No Content
[InlineData(299)] // Edge of success range
public void HandleResponse_RangeIncludesSuccess_SuccessNotCaptured(int statusCode)
public void HandleResponse_RangeIncludesSuccess_DontCapture(int statusCode)
{
// Arrange
var options = new SentryOptions
Expand Down Expand Up @@ -173,7 +172,7 @@ public void HandleResponse_RequestsToSentryDsn_DontCapture()
}

[Fact]
public void HandleResponse_NoMatchingTarget_DontCapture()
public void HandleResponse_NoMatchingFailedRequestTarget_DontCapture()
{
// Arrange
var options = new SentryOptions
Expand All @@ -194,7 +193,7 @@ public void HandleResponse_NoMatchingTarget_DontCapture()
}

[Fact]
public void HandleResponse_Capture_FailedRequest()
public void HandleResponse_FailedRequest_DoCapture()
{
// Arrange
var options = new SentryOptions
Expand All @@ -214,7 +213,7 @@ public void HandleResponse_Capture_FailedRequest()
}

[Fact]
public void HandleResponse_Capture_FailedRequest_No_Pii()
public void HandleResponse_FailedRequestNoPii_DoCaptureWithoutPii()
{
// Arrange
var options = new SentryOptions
Expand Down Expand Up @@ -321,7 +320,7 @@ public void HandleResponse_Capture_Default_SkipCookiesAndHeaders()
}

[Fact]
public void HandleResponse_Hint_Response()
public void HandleResponse_Hint_DoCaptureHint()
{
// Arrange
var options = new SentryOptions
Expand Down