Skip to content

Conversation

@akoeplinger
Copy link
Contributor

Before the flag was added even if you built for an android RID on windows, causing an error.

…ts in Sentry.Native.targets

Before the flag was added even if you built for an android RID on windows, causing an error.
@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.87%. Comparing base (356f8e9) to head (826d342).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4760      +/-   ##
==========================================
+ Coverage   73.85%   73.87%   +0.01%     
==========================================
  Files         485      485              
  Lines       17689    17689              
  Branches     3496     3497       +1     
==========================================
+ Hits        13064    13067       +3     
+ Misses       3765     3761       -4     
- Partials      860      861       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@jamescrosswell jamescrosswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - thank you @akoeplinger ❤️

The only thing missing is a change log... which typically describes the impact for SDK users. If there is no impact, it can be skipped but in this case I think it would resolve some build issues for folks building on Windows, so worth adding.

@akoeplinger
Copy link
Contributor Author

@jamescrosswell done

@Flash0ver
Copy link
Member

@sentry review

@sentry
Copy link

sentry bot commented Nov 24, 2025

Seer had some issues with your request. Please try again.
Reference ID: 3180744

Copy link
Collaborator

@jamescrosswell jamescrosswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic - thank you @akoeplinger!

@jamescrosswell jamescrosswell merged commit e10c6d5 into getsentry:main Nov 25, 2025
51 of 52 checks passed
@akoeplinger akoeplinger deleted the fix-linkerarg branch November 26, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants