-
-
Notifications
You must be signed in to change notification settings - Fork 226
Move setting /NODEFAULTLIB:MSVCRT LinkerArg to windows-specific targets in Sentry.Native.targets #4760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ts in Sentry.Native.targets Before the flag was added even if you built for an android RID on windows, causing an error.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4760 +/- ##
==========================================
+ Coverage 73.85% 73.87% +0.01%
==========================================
Files 485 485
Lines 17689 17689
Branches 3496 3497 +1
==========================================
+ Hits 13064 13067 +3
+ Misses 3765 3761 -4
- Partials 860 861 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jamescrosswell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome - thank you @akoeplinger ❤️
The only thing missing is a change log... which typically describes the impact for SDK users. If there is no impact, it can be skipped but in this case I think it would resolve some build issues for folks building on Windows, so worth adding.
|
@jamescrosswell done |
|
@sentry review |
|
Seer had some issues with your request. Please try again. |
jamescrosswell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic - thank you @akoeplinger!
Before the flag was added even if you built for an android RID on windows, causing an error.