Skip to content

Move setting /NODEFAULTLIB:MSVCRT LinkerArg to windows-specific targets in Sentry.Native.targets #4760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamescrosswell merged 3 commits into from
Nov 25, 2025
Merged

Move setting /NODEFAULTLIB:MSVCRT LinkerArg to windows-specific targets in Sentry.Native.targets #4760

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec5ee8a
Move setting /NODEFAULTLIB:MSVCRT LinkerArg to windows-specific targe…
akoeplinger Nov 21, 2025
ff22ee5
Update CHANGELOG.md
akoeplinger Nov 24, 2025
826d342
Update CHANGELOG.md
akoeplinger Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Move setting /NODEFAULTLIB:MSVCRT LinkerArg to windows-specific targe… 
…ts in Sentry.Native.targets

Before the flag was added even if you built for an android RID on windows, causing an error.
  • Loading branch information
@akoeplinger
akoeplinger authored Nov 21, 2025
commit ec5ee8abd8aff78210f844c57dc354a1f9b52fe3
2 changes: 2 additions & 0 deletions src/Sentry/Platforms/Native/buildTransitive/Sentry.Native.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@

<ItemGroup Condition="'$(FrameworkSupportsNative)' == 'true' and ('$(RuntimeIdentifier)' == 'win-x64' or '$(RuntimeIdentifier)' == 'win-arm64')">
<DirectPInvoke Include="sentry-native" />
<!-- See: https://github.com/getsentry/sentry-dotnet/pull/4111 -->
<LinkerArg Include="/NODEFAULTLIB:MSVCRT" />
<NativeLibrary Include="$(MSBuildThisFileDirectory)..\sentry-native\$(RuntimeIdentifier)\sentry-native.lib" />
<NativeLibrary Include="dbghelp.lib" />
<NativeLibrary Include="winhttp.lib" />
Expand Down
5 changes: 0 additions & 5 deletions src/Sentry/buildTransitive/Sentry.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,6 @@
<Error Text="Android projects using Sentry cannot build using AndroidEnableAssemblyCompression = false due to a Microsoft issue. Please follow https://github.com/dotnet/android/issues/9752" />
</Target>

<ItemGroup Condition="$([MSBuild]::IsOSPlatform('Windows')) AND '$(UsingMicrosoftNETSdkBlazorWebAssembly)' != 'true'">
<!-- See: https://github.com/getsentry/sentry-dotnet/pull/4111 -->
<LinkerArg Include="/NODEFAULTLIB:MSVCRT" />
</ItemGroup>

<Target Name="WriteSentryAttributes"
Condition="$(Language) == 'VB' or $(Language) == 'C#' or $(Language) == 'F#'"
BeforeTargets="BeforeCompile;CoreCompile"
Expand Down
Loading