feat: Update to v7 JavaScript SDKs #471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timfish
force-pushed
the
feat/v7-javascript
branch
from
92344a3 to
9b6e00f
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Closed
timfish
force-pushed
the
feat/v7-javascript
branch
from
12760c6 to
ccffa8b
Compare
timfish
commented
May 30, 2022
This comment was marked as outdated.
This comment was marked as outdated.
AbhiPrasad
approved these changes
Jun 29, 2022
|
|
||
| // We handle beforeSend and sampleRate manually here because native crashes do not go through @sentry/core | ||
| const { beforeSend, sampleRate } = options; | ||
| if (typeof sampleRate === 'number' && Math.random() > sampleRate) { |
Member
There was a problem hiding this comment.
Why did we get rid of this logic here?
Collaborator
Author
There was a problem hiding this comment.
beforeSend and sampleRate handling now all occur in @sentry/core.
This only existed before because native crashes were not sent through the underlying JavaScript SDK and were instead hacked on top of the transport.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading to v7 of the Sentry JavaScript SDKs:
forgethelperisolatedModulesCloses #496, #481, #487, #489 and #497