Skip to content

feat(core): Add updateSpanName helper function #14291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lms24 merged 18 commits into from
Dec 16, 2024
Merged

feat(core): Add updateSpanName helper function #14291

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
1be63e2
feat(core): Add `updateSpanName` helper function
Lms24 Nov 14, 2024
7886728
add exports
Lms24 Nov 14, 2024
3028f45
node tests and jsdoc
Lms24 Nov 14, 2024
1cfb1c2
browser integration test
Lms24 Nov 14, 2024
ff6001f
more unit tests
Lms24 Nov 14, 2024
914ce83
possibly fix minified bundle tests
Lms24 Dec 11, 2024
dcde038
remove unnecessary test
Lms24 Nov 14, 2024
4416722
jsdoc update
Lms24 Nov 14, 2024
9534810
adjust parseSpanDescription and tests
Lms24 Nov 15, 2024
5e69e6a
fix integration test
Lms24 Dec 12, 2024
99dc49a
size limit
Lms24 Dec 12, 2024
64437ed
s/_sentry_span_name_set_by_user/SEMANTIC_ATTRIBUTE_SENTRY_CUSTOM_SPAN…
Lms24 Dec 13, 2024
1772a77
remove impl detail in Span JSDoc
Lms24 Dec 13, 2024
24e8320
remove span attributes separately for otel and sentry spans
Lms24 Dec 13, 2024
983a48b
biome
Lms24 Dec 13, 2024
f4a3e89
fix wrong attribute used
Lms24 Dec 13, 2024
f8b614c
remove leftover deletion and logs
Lms24 Dec 13, 2024
87a4d93
biome :(
Lms24 Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix wrong attribute used
  • Loading branch information
@Lms24
Lms24 committed Dec 13, 2024
commit f4a3e89f234552a48359de88c829329a2f9eaa88
2 changes: 1 addition & 1 deletion packages/opentelemetry/src/utils/parseSpanDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ export function parseSpanDescription(span: AbstractSpan): SpanDescription {

function descriptionForDbSystem({ attributes, name }: { attributes: Attributes; name: string }): SpanDescription {
// if we already have a custom name, we don't overwrite it but only set the op
const userDefinedName = attributes[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE];
const userDefinedName = attributes[SEMANTIC_ATTRIBUTE_SENTRY_CUSTOM_SPAN_NAME];
if (typeof userDefinedName === 'string') {
return {
op: 'db',
Expand Down
Loading