Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ref; use featureFlags util functions
  • Loading branch information
billyvg committed Nov 20, 2024
commit 06e7fbb1be91703903819fc43a27ceadefe5f89a
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,7 @@ import type { Client, Event, EventHint, IntegrationFn } from '@sentry/types';
import type { LDContext, LDEvaluationDetail, LDInspectionFlagUsedHandler } from './types';

import { defineIntegration } from '@sentry/core';
<<<<<<< HEAD
import { copyFlagsFromScopeToEvent, insertFlagToScope } from '../../../utils/featureFlags';
=======
import { copyFlagsFromScopeToEvent, insertToFlagBuffer } from '../../../utils/featureFlags';
>>>>>>> 0f32cb567 (ref(flags): Refactor LaunchDarkly integration to reusable functions)

/**
* Sentry integration for capturing feature flags from LaunchDarkly.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,25 +6,17 @@
* - OpenFeature.getClient().addHooks(new OpenFeatureIntegrationHook());
*/
import type { Client, Event, EventHint, IntegrationFn } from '@sentry/types';
import type { EvaluationDetails, FlagValue, HookContext, HookHints, JsonValue, OpenFeatureHook } from './types';
import type { EvaluationDetails, HookContext, HookHints, JsonValue, OpenFeatureHook } from './types';

import { defineIntegration, getCurrentScope } from '@sentry/core';
import { insertToFlagBuffer } from '../../../utils/featureFlags';
import { defineIntegration } from '@sentry/core';
import { copyFlagsFromScopeToEvent, insertFlagToScope } from '../../../utils/featureFlags';

export const openFeatureIntegration = defineIntegration(() => {
return {
name: 'OpenFeature',

processEvent(event: Event, _hint: EventHint, _client: Client): Event {
const scope = getCurrentScope();
const flagContext = scope.getScopeData().contexts.flags;
const flagBuffer = flagContext ? flagContext.values : [];

if (event.contexts === undefined) {
event.contexts = {};
}
event.contexts.flags = { values: [...flagBuffer] };
return event;
return copyFlagsFromScopeToEvent(event);
},
};
}) satisfies IntegrationFn;
Expand All @@ -37,25 +29,13 @@ export class OpenFeatureIntegrationHook implements OpenFeatureHook {
* Successful evaluation result.
*/
public after(_hookContext: Readonly<HookContext<JsonValue>>, evaluationDetails: EvaluationDetails<JsonValue>): void {
processEvent(evaluationDetails.flagKey, evaluationDetails.value);
insertFlagToScope(evaluationDetails.flagKey, evaluationDetails.value);
}

/**
* On error evaluation result.
*/
public error(hookContext: Readonly<HookContext<JsonValue>>, _error: unknown, _hookHints?: HookHints): void {
processEvent(hookContext.flagKey, hookContext.defaultValue);
}
}

function processEvent(key: string, value: FlagValue): void {
if (typeof value === 'boolean') {
const scopeContexts = getCurrentScope().getScopeData().contexts;
if (!scopeContexts.flags) {
scopeContexts.flags = { values: [] };
}
const flagBuffer = scopeContexts.flags.values;
insertToFlagBuffer(flagBuffer, key, value);
insertFlagToScope(hookContext.flagKey, hookContext.defaultValue);
}
return;
}